From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42643) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zw91x-0008DU-Fp for qemu-devel@nongnu.org; Tue, 10 Nov 2015 08:32:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zw91t-0000t6-L8 for qemu-devel@nongnu.org; Tue, 10 Nov 2015 08:32:13 -0500 Received: from mx1.redhat.com ([209.132.183.28]:50962) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zw91t-0000sz-Cr for qemu-devel@nongnu.org; Tue, 10 Nov 2015 08:32:09 -0500 From: Stefan Hajnoczi Date: Tue, 10 Nov 2015 13:31:41 +0000 Message-Id: <1447162308-8517-9-git-send-email-stefanha@redhat.com> In-Reply-To: <1447162308-8517-1-git-send-email-stefanha@redhat.com> References: <1447162308-8517-1-git-send-email-stefanha@redhat.com> Subject: [Qemu-devel] [PULL 08/15] trace: no need to call trace_backend_init in different branches now List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Peter Maydell , Paolo Bonzini , Stefan Hajnoczi , "Denis V. Lunev" From: "Denis V. Lunev" original idea to split calling locations was to spawn tracing thread in the final child process according to commit 8a745f2a9296ad2cf6bda33534ed298f2625a4ad Author: Michael Mueller Date: Mon Sep 23 16:36:54 2013 +0200 os_daemonize is now on top of both locations. Drop unneeded ifs. Signed-off-by: Denis V. Lunev Reviewed-by: Paolo Bonzini Signed-off-by: Paolo Bonzini Message-id: 1446151457-21157-5-git-send-email-den@openvz.org Signed-off-by: Stefan Hajnoczi --- vl.c | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/vl.c b/vl.c index b567ed9..a9c3449 100644 --- a/vl.c +++ b/vl.c @@ -4113,10 +4113,8 @@ int main(int argc, char **argv, char **envp) qemu_set_log(mask); } - if (!is_daemonized()) { - if (!trace_init_backends()) { - exit(1); - } + if (!trace_init_backends()) { + exit(1); } /* If no data_dir is specified then try to find it relative to the @@ -4676,12 +4674,6 @@ int main(int argc, char **argv, char **envp) os_setup_post(); - if (is_daemonized()) { - if (!trace_init_backends()) { - exit(1); - } - } - main_loop(); replay_disable_events(); -- 2.5.0