From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PULL 6/7] hw/arm/virt: error_report cleanups
Date: Tue, 10 Nov 2015 13:51:46 +0000 [thread overview]
Message-ID: <1447163507-26627-7-git-send-email-peter.maydell@linaro.org> (raw)
In-Reply-To: <1447163507-26627-1-git-send-email-peter.maydell@linaro.org>
From: Andrew Jones <drjones@redhat.com>
Signed-off-by: Andrew Jones <drjones@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Message-id: 1446909925-12201-1-git-send-email-drjones@redhat.com
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
hw/arm/virt.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/hw/arm/virt.c b/hw/arm/virt.c
index 77d9267..9c6792c 100644
--- a/hw/arm/virt.c
+++ b/hw/arm/virt.c
@@ -941,8 +941,8 @@ static void machvirt_init(MachineState *machine)
if (!gic_version) {
gic_version = kvm_arm_vgic_probe();
if (!gic_version) {
- error_report("Unable to determine GIC version supported by host\n"
- "Probably KVM acceleration is not supported\n");
+ error_report("Unable to determine GIC version supported by host");
+ error_printf("KVM acceleration is probably not supported\n");
exit(1);
}
}
@@ -990,7 +990,7 @@ static void machvirt_init(MachineState *machine)
char *cpuopts = g_strdup(cpustr[1]);
if (!oc) {
- fprintf(stderr, "Unable to find CPU definition\n");
+ error_report("Unable to find CPU definition");
exit(1);
}
cpuobj = object_new(object_class_get_name(oc));
@@ -1126,8 +1126,8 @@ static void virt_set_gic_version(Object *obj, const char *value, Error **errp)
} else if (!strcmp(value, "host")) {
vms->gic_version = 0; /* Will probe later */
} else {
- error_report("Invalid gic-version option value\n"
- "Allowed values are: 3, 2, host\n");
+ error_report("Invalid gic-version option value");
+ error_printf("Allowed gic-version values are: 3, 2, host\n");
exit(1);
}
}
--
1.9.1
next prev parent reply other threads:[~2015-11-10 13:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-10 13:51 [Qemu-devel] [PULL 0/7] target-arm queue Peter Maydell
2015-11-10 13:51 ` [Qemu-devel] [PULL 1/7] target-arm: Fix gdb singlestep handling in arm_debug_excp_handler() Peter Maydell
2015-11-10 13:51 ` [Qemu-devel] [PULL 2/7] hw/intc/arm_gic: Remove the definition of NUM_CPU Peter Maydell
2015-11-10 13:51 ` [Qemu-devel] [PULL 3/7] arm: boot: Add secure_board_setup flag Peter Maydell
2015-11-10 13:51 ` [Qemu-devel] [PULL 4/7] arm: highbank: Defeature CPU override Peter Maydell
2015-11-10 13:51 ` [Qemu-devel] [PULL 5/7] arm: highbank: Implement PSCI and dummy monitor Peter Maydell
2015-11-10 13:51 ` Peter Maydell [this message]
2015-11-10 13:51 ` [Qemu-devel] [PULL 7/7] target-arm: Clean up DISAS_UPDATE usage in AArch32 translation code Peter Maydell
2015-11-10 16:38 ` [Qemu-devel] [PULL 0/7] target-arm queue Peter Maydell
2015-11-10 17:12 ` Peter Crosthwaite
2015-11-10 17:13 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1447163507-26627-7-git-send-email-peter.maydell@linaro.org \
--to=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).