From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47408) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zw9Kw-0004Rv-N7 for qemu-devel@nongnu.org; Tue, 10 Nov 2015 08:51:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zw9Kv-0006HY-NE for qemu-devel@nongnu.org; Tue, 10 Nov 2015 08:51:50 -0500 Received: from mnementh.archaic.org.uk ([2001:8b0:1d0::1]:35389) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zw9Kv-0006HI-GS for qemu-devel@nongnu.org; Tue, 10 Nov 2015 08:51:49 -0500 Received: from pm215 by mnementh.archaic.org.uk with local (Exim 4.80) (envelope-from ) id 1Zw9Kt-0006wP-PM for qemu-devel@nongnu.org; Tue, 10 Nov 2015 13:51:47 +0000 From: Peter Maydell Date: Tue, 10 Nov 2015 13:51:46 +0000 Message-Id: <1447163507-26627-7-git-send-email-peter.maydell@linaro.org> In-Reply-To: <1447163507-26627-1-git-send-email-peter.maydell@linaro.org> References: <1447163507-26627-1-git-send-email-peter.maydell@linaro.org> Subject: [Qemu-devel] [PULL 6/7] hw/arm/virt: error_report cleanups List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org From: Andrew Jones Signed-off-by: Andrew Jones Reviewed-by: Markus Armbruster Message-id: 1446909925-12201-1-git-send-email-drjones@redhat.com Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell --- hw/arm/virt.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index 77d9267..9c6792c 100644 --- a/hw/arm/virt.c +++ b/hw/arm/virt.c @@ -941,8 +941,8 @@ static void machvirt_init(MachineState *machine) if (!gic_version) { gic_version = kvm_arm_vgic_probe(); if (!gic_version) { - error_report("Unable to determine GIC version supported by host\n" - "Probably KVM acceleration is not supported\n"); + error_report("Unable to determine GIC version supported by host"); + error_printf("KVM acceleration is probably not supported\n"); exit(1); } } @@ -990,7 +990,7 @@ static void machvirt_init(MachineState *machine) char *cpuopts = g_strdup(cpustr[1]); if (!oc) { - fprintf(stderr, "Unable to find CPU definition\n"); + error_report("Unable to find CPU definition"); exit(1); } cpuobj = object_new(object_class_get_name(oc)); @@ -1126,8 +1126,8 @@ static void virt_set_gic_version(Object *obj, const char *value, Error **errp) } else if (!strcmp(value, "host")) { vms->gic_version = 0; /* Will probe later */ } else { - error_report("Invalid gic-version option value\n" - "Allowed values are: 3, 2, host\n"); + error_report("Invalid gic-version option value"); + error_printf("Allowed gic-version values are: 3, 2, host\n"); exit(1); } } -- 1.9.1