From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59852) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZwCAO-0001Mm-7p for qemu-devel@nongnu.org; Tue, 10 Nov 2015 11:53:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZwCAK-00034S-SY for qemu-devel@nongnu.org; Tue, 10 Nov 2015 11:53:08 -0500 Received: from mx1.redhat.com ([209.132.183.28]:53612) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZwCAK-00034G-Mc for qemu-devel@nongnu.org; Tue, 10 Nov 2015 11:53:04 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id 1937442E5B7 for ; Tue, 10 Nov 2015 16:53:04 +0000 (UTC) From: Juan Quintela Date: Tue, 10 Nov 2015 17:52:59 +0100 Message-Id: <1447174381-7171-1-git-send-email-quintela@redhat.com> Subject: [Qemu-devel] [PATCH 0/2] Clean up 32bit compilation for Migration List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: amit.shah@redhat.com, dgilbert@redhat.com Hi We had two warnings on 32bit targets. With this change I am able to compile with -Werror on: - linux 64bit - linux 32bit - windows 32bit (cross-compile with Fedora mingw64) - windows 64bit (cross-compile with Fedora mingw64) I am lying in this one, really my crosscompiler for windows 64 bit barf at CXX disas/libvixl/a64/disasm-a64.o /mnt/kvm/qemu/next/disas/libvixl/a64/disasm-a64.cc: In member function 'virtual void vixl::Disassembler::AppendPCRelativeOffsetToOutput(const vixl::Instruction*, int64_t)': /mnt/kvm/qemu/next/disas/libvixl/a64/disasm-a64.cc:1365:57: error: unknown conversion type character 'l' in format [-Werror=format=] AppendToOutput("#%c0x%" PRIx64, sign, std::abs(offset)); ^ /mnt/kvm/qemu/next/disas/libvixl/a64/disasm-a64.cc:1365:57: error: too many arguments for format [-Werror=format-extra-args] /mnt/kvm/qemu/next/disas/libvixl/a64/disasm-a64.cc: In member function 'virtual void vixl::Disassembler::AppendAddressToOutput(const vixl::Instruction*, const void*)': /mnt/kvm/qemu/next/disas/libvixl/a64/disasm-a64.cc:1372:76: error: unknown conversion type character 'l' in format [-Werror=format=] AppendToOutput("(addr 0x%" PRIxPTR ")", reinterpret_cast(addr)); ^ /mnt/kvm/qemu/next/disas/libvixl/a64/disasm-a64.cc:1372:76: error: too many arguments for format [-Werror=format-extra-args] /mnt/kvm/qemu/next/disas/libvixl/a64/disasm-a64.cc: In member function 'virtual void vixl::Disassembler::AppendCodeRelativeAddressToOutput(const vixl::Instruction*, const void*)': /mnt/kvm/qemu/next/disas/libvixl/a64/disasm-a64.cc:1393:52: error: unknown conversion type character 'l' in format [-Werror=format=] AppendToOutput("(addr 0x%" PRIx64 ")", rel_addr); ^ /mnt/kvm/qemu/next/disas/libvixl/a64/disasm-a64.cc:1393:52: error: too many arguments for format [-Werror=format-extra-args] /mnt/kvm/qemu/next/disas/libvixl/a64/disasm-a64.cc:1395:54: error: unknown conversion type character 'l' in format [-Werror=format=] AppendToOutput("(addr -0x%" PRIx64 ")", -rel_addr); ^ ..... I am wondering if it really understand PRI*64 at all. Please, review. Juan. Juan Quintela (2): migration: print ram_addr_t as RAM_ADDR_FMT not %zx migration: Make 32bit linux compile with RDMA migration/ram.c | 5 +++-- migration/rdma.c | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) -- 2.5.0