From: Thomas Huth <thuth@redhat.com>
To: qemu-devel@nongnu.org, qemu-trivial@nongnu.org
Cc: John Snow <jsnow@redhat.com>, qemu-block@nongnu.org
Subject: [Qemu-devel] [PATCH 1/4] hw/ide: Remove superfluous return statements
Date: Tue, 10 Nov 2015 21:16:08 +0100 [thread overview]
Message-ID: <1447186571-27672-2-git-send-email-thuth@redhat.com> (raw)
In-Reply-To: <1447186571-27672-1-git-send-email-thuth@redhat.com>
The "return;" statements at the end of functions do not make
much sense, so let's remove them.
Cc: John Snow <jsnow@redhat.com>
Cc: qemu-block@nongnu.org
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
hw/ide/atapi.c | 1 -
hw/ide/macio.c | 2 --
2 files changed, 3 deletions(-)
diff --git a/hw/ide/atapi.c b/hw/ide/atapi.c
index 747f466..347c6e7 100644
--- a/hw/ide/atapi.c
+++ b/hw/ide/atapi.c
@@ -737,7 +737,6 @@ static void cmd_inquiry(IDEState *s, uint8_t *buf)
out:
buf[size_idx] = idx - preamble_len;
ide_atapi_cmd_reply(s, idx, max_len);
- return;
}
static void cmd_get_configuration(IDEState *s, uint8_t *buf)
diff --git a/hw/ide/macio.c b/hw/ide/macio.c
index 893c9b9..8a56115 100644
--- a/hw/ide/macio.c
+++ b/hw/ide/macio.c
@@ -288,8 +288,6 @@ static void pmac_ide_atapi_transfer_cb(void *opaque, int ret)
done:
block_acct_done(blk_get_stats(s->blk), &s->acct);
io->dma_end(opaque);
-
- return;
}
static void pmac_ide_transfer_cb(void *opaque, int ret)
--
1.8.3.1
next prev parent reply other threads:[~2015-11-10 20:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-10 20:16 [Qemu-devel] [PATCH 0/4] Remove superfluous return statements Thomas Huth
2015-11-10 20:16 ` Thomas Huth [this message]
2015-11-10 20:17 ` [Qemu-devel] [PATCH 1/4] hw/ide: " John Snow
2015-11-10 20:16 ` [Qemu-devel] [PATCH 2/4] hw/acpi: Remove superfluous return statement Thomas Huth
2015-11-10 20:16 ` [Qemu-devel] [PATCH 3/4] hw/s390x: Remove superfluous return statements Thomas Huth
2015-11-11 11:25 ` Cornelia Huck
2015-11-11 13:29 ` Thomas Huth
2015-11-10 20:16 ` [Qemu-devel] [PATCH 4/4] hw/core/qdev: Remove superfluous return statement Thomas Huth
2016-01-11 8:29 ` [Qemu-devel] [PATCH 0/4] Remove superfluous return statements Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1447186571-27672-2-git-send-email-thuth@redhat.com \
--to=thuth@redhat.com \
--cc=jsnow@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).