From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53159) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZwVqG-0001bN-S0 for qemu-devel@nongnu.org; Wed, 11 Nov 2015 08:53:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZwVq6-0007h7-8G for qemu-devel@nongnu.org; Wed, 11 Nov 2015 08:53:40 -0500 Received: from mail-wm0-x234.google.com ([2a00:1450:400c:c09::234]:38520) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZwVq6-0007h2-1q for qemu-devel@nongnu.org; Wed, 11 Nov 2015 08:53:30 -0500 Received: by wmec201 with SMTP id c201so47527600wme.1 for ; Wed, 11 Nov 2015 05:53:29 -0800 (PST) From: Leonid Bloch Date: Wed, 11 Nov 2015 15:52:44 +0200 Message-Id: <1447249967-10932-7-git-send-email-leonid.bloch@ravellosystems.com> In-Reply-To: <1447249967-10932-1-git-send-email-leonid.bloch@ravellosystems.com> References: <1447249967-10932-1-git-send-email-leonid.bloch@ravellosystems.com> Subject: [Qemu-devel] [PATCH v6 6/9] e1000: Fixing the received/transmitted octets' counters List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Dmitry Fleytman , Jason Wang , Leonid Bloch , Shmulik Ladkani Previously, these 64-bit registers did not stick at their maximal values when (and if) they reached them, as they should do, according to the specs. This patch introduces a function that takes care of such registers, avoiding code duplication, making the relevant parts more compatible with the QEMU coding style, while ensuring that in the unlikely case of reaching the maximal value, the counter will stick there, as it supposed to. Signed-off-by: Leonid Bloch Signed-off-by: Dmitry Fleytman --- hw/net/e1000.c | 26 ++++++++++++++++++-------- 1 file changed, 18 insertions(+), 8 deletions(-) diff --git a/hw/net/e1000.c b/hw/net/e1000.c index 57a61f6..9967b5d 100644 --- a/hw/net/e1000.c +++ b/hw/net/e1000.c @@ -588,6 +588,20 @@ inc_reg_if_not_full(E1000State *s, int index) } } +static void +grow_8reg_if_not_full(E1000State *s, int index, int size) +{ + uint64_t sum = s->mac_reg[index] | (uint64_t)s->mac_reg[index+1] << 32; + + if (sum + size < sum) { + sum = ~0ULL; + } else { + sum += size; + } + s->mac_reg[index] = sum; + s->mac_reg[index+1] = sum >> 32; +} + static inline int vlan_enabled(E1000State *s) { @@ -637,7 +651,7 @@ static void xmit_seg(E1000State *s) { uint16_t len, *sp; - unsigned int frames = s->tx.tso_frames, css, sofar, n; + unsigned int frames = s->tx.tso_frames, css, sofar; struct e1000_tx *tp = &s->tx; if (tp->tse && tp->cptse) { @@ -686,10 +700,8 @@ xmit_seg(E1000State *s) } inc_reg_if_not_full(s, TPT); + grow_8reg_if_not_full(s, TOTL, s->tx.size); s->mac_reg[GPTC] = s->mac_reg[TPT]; - n = s->mac_reg[TOTL]; - if ((s->mac_reg[TOTL] += s->tx.size) < n) - s->mac_reg[TOTH]++; } static void @@ -1104,11 +1116,9 @@ e1000_receive_iov(NetClientState *nc, const struct iovec *iov, int iovcnt) /* TOR - Total Octets Received: * This register includes bytes received in a packet from the field through the field, inclusively. + * Always include FCS length (4) in size. */ - n = s->mac_reg[TORL] + size + /* Always include FCS length. */ 4; - if (n < s->mac_reg[TORL]) - s->mac_reg[TORH]++; - s->mac_reg[TORL] = n; + grow_8reg_if_not_full(s, TORL, size+4); n = E1000_ICS_RXT0; if ((rdt = s->mac_reg[RDT]) < s->mac_reg[RDH]) -- 2.4.3