qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
To: qemu-devel@nongnu.org, quintela@redhat.com, amit.shah@redhat.com
Cc: bharata@linux.vnet.ibm.com
Subject: [Qemu-devel] [PATCH 3/3] migrate-start-postcopy: Improve text
Date: Wed, 11 Nov 2015 14:02:29 +0000	[thread overview]
Message-ID: <1447250549-10291-4-git-send-email-dgilbert@redhat.com> (raw)
In-Reply-To: <1447250549-10291-1-git-send-email-dgilbert@redhat.com>

From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>

Improve the text in both the qapi-schema and hmp help to point out
you need to set the postcopy-ram capability prior to issuing
migrate-start-postcopy.

Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
---
 hmp-commands.hx  | 4 +++-
 qapi-schema.json | 3 ++-
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/hmp-commands.hx b/hmp-commands.hx
index 8939b98..3316ee3 100644
--- a/hmp-commands.hx
+++ b/hmp-commands.hx
@@ -1011,7 +1011,9 @@ ETEXI
         .name       = "migrate_start_postcopy",
         .args_type  = "",
         .params     = "",
-        .help       = "Switch migration to postcopy mode",
+        .help       = "Switch current migration to postcopy mode; "
+                      "the x-postcopy-ram capability must be set before"
+                      " issuing this command.",
         .mhandler.cmd = hmp_migrate_start_postcopy,
     },
 
diff --git a/qapi-schema.json b/qapi-schema.json
index 8c3a42a..2d1845a 100644
--- a/qapi-schema.json
+++ b/qapi-schema.json
@@ -706,7 +706,8 @@
 ##
 # @migrate-start-postcopy
 #
-# Switch migration to postcopy mode
+# Switch current migration to postcopy mode; the x-postcopy-ram capability
+# must be set before issuing this command.
 #
 # Since: 2.5
 { 'command': 'migrate-start-postcopy' }
-- 
2.5.0

  parent reply	other threads:[~2015-11-11 14:02 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-11 14:02 [Qemu-devel] [PATCH 0/3] Postcopy minor fixes Dr. David Alan Gilbert (git)
2015-11-11 14:02 ` [Qemu-devel] [PATCH 1/3] Finish non-postcopiable iterative devices before package Dr. David Alan Gilbert (git)
2015-11-11 15:14   ` Juan Quintela
2015-11-11 14:02 ` [Qemu-devel] [PATCH 2/3] Postcopy: Fix TP!=HP zero case Dr. David Alan Gilbert (git)
2015-11-11 15:11   ` Juan Quintela
2015-11-11 14:02 ` Dr. David Alan Gilbert (git) [this message]
2015-11-11 15:07   ` [Qemu-devel] [PATCH 3/3] migrate-start-postcopy: Improve text Juan Quintela
2015-11-11 16:34   ` Eric Blake
2015-11-11 20:59 ` [Qemu-devel] [PATCH 0/3] Postcopy minor fixes Christian Borntraeger
2015-11-12  8:59   ` Dr. David Alan Gilbert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1447250549-10291-4-git-send-email-dgilbert@redhat.com \
    --to=dgilbert@redhat.com \
    --cc=amit.shah@redhat.com \
    --cc=bharata@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).