From: Eric Blake <eblake@redhat.com>
To: qemu-devel@nongnu.org
Cc: armbru@redhat.com
Subject: [Qemu-devel] [PATCH for-2.5 0/4] Expose ErrorClass through introspection
Date: Wed, 11 Nov 2015 18:17:38 -0700 [thread overview]
Message-ID: <1447291062-11011-1-git-send-email-eblake@redhat.com> (raw)
I noticed that introspection was not documenting either
qmp_capabilities nor the ErrorClass enum. I think this is worth
fixing for 2.5 when introspection is brand new, so that if we later
extend the ErrorClass enum or add future capability negotiation (and
in particular if such additions get backported in downstream builds),
a client will be able to use introspection to learn whether the new
features are supported, regardless of the qemu version.
Note that this also adds qmp_capabilities to 'query-commands'.
Yes, this is borderline, and you may decide that it doesn't deserve
to be called a bug and should wait for 2.6.
Eric Blake (3):
qapi: Add type.is_empty() helper
qapi: Fix command with named empty argument type
qapi: Expose ErrorClass through introspection
Marc-André Lureau (1):
monitor: use qapi for qmp_capabilities command
docs/qmp-spec.txt | 16 ++++++++++++++++
monitor.c | 8 ++++++--
qapi-schema.json | 32 ++++++++++++++++++++++++++++++++
qmp-commands.hx | 4 ++--
scripts/qapi-commands.py | 6 +++---
scripts/qapi-event.py | 6 +++---
scripts/qapi-types.py | 2 +-
scripts/qapi.py | 3 +++
tests/qapi-schema/qapi-schema-test.json | 2 ++
tests/qapi-schema/qapi-schema-test.out | 2 ++
tests/test-qmp-commands.c | 5 +++++
11 files changed, 75 insertions(+), 11 deletions(-)
--
2.4.3
next reply other threads:[~2015-11-12 1:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-12 1:17 Eric Blake [this message]
2015-11-12 1:17 ` [Qemu-devel] [PATCH for-2.5 1/4] qapi: Add type.is_empty() helper Eric Blake
2015-11-12 1:17 ` [Qemu-devel] [PATCH for-2.5 2/4] qapi: Fix command with named empty argument type Eric Blake
2015-11-12 1:17 ` [Qemu-devel] [PATCH for-2.5 3/4] monitor: use qapi for qmp_capabilities command Eric Blake
2015-11-12 1:17 ` [Qemu-devel] [PATCH for-2.5 4/4] qapi: Expose ErrorClass through introspection Eric Blake
2015-11-12 10:48 ` [Qemu-devel] [PATCH for-2.5 0/4] " Markus Armbruster
2015-11-12 13:28 ` Eric Blake
2015-11-12 10:48 ` Markus Armbruster
2015-11-12 13:37 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1447291062-11011-1-git-send-email-eblake@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).