From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51107) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZwnsX-0006SI-9S for qemu-devel@nongnu.org; Thu, 12 Nov 2015 04:09:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZwnsS-0002ge-5Q for qemu-devel@nongnu.org; Thu, 12 Nov 2015 04:09:13 -0500 Received: from mx1.redhat.com ([209.132.183.28]:41956) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZwnsR-0002ga-W8 for qemu-devel@nongnu.org; Thu, 12 Nov 2015 04:09:08 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 86CEE8E74B for ; Thu, 12 Nov 2015 09:09:07 +0000 (UTC) Message-ID: <1447319343.1400.39.camel@redhat.com> From: Gerd Hoffmann Date: Thu, 12 Nov 2015 10:09:03 +0100 In-Reply-To: <87d1vfvd7d.fsf@blackfin.pond.sub.org> References: <1447279028-2114-1-git-send-email-eblake@redhat.com> <1447279028-2114-3-git-send-email-eblake@redhat.com> <87d1vfvd7d.fsf@blackfin.pond.sub.org> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH for-2.5 2/2] input: Promote 'input-send-event' to stable API List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-devel@nongnu.org On Do, 2015-11-12 at 09:23 +0100, Markus Armbruster wrote: > Eric Blake writes: > > > We've had 'x-input-send-event' since 2.3, with no further > > changes to the interface other than tweaks in the previous patch > > to the spelling of the enum constants ('X' and 'WheelUp' changed > > to 'x' and 'wheel-up'). > > > > What's more, changing the spelling of enum constants is not easy > > to introspect prior to 2.5; so a client that was relying on the > > experimental command can't easily tell which spelling is expected. > > But 'query-commands' works in all qemu versions that supported > > the command, so renaming the command now makes it an easy thing > > to determine which spelling of the enum values to use. > > > > Thus, it's time to promote this interface to stable. > > The x- goes back to commit df5b2ad: > > input: move input-send-event into experimental namespace > > Ongoing discussions on how we are going to specify the console, > so tag the command as experiental so we can refine things in > the 2.3 development cycle. > > Have we settled "how we are going to specify the console"? If yes, > commit, please. If no, I'm afraid the command should stay experimental. Good question. I don't think so. IIRC the question was whenever we'll leave it as-is (console=), or whenever we'll do something like display=,head= instead. The latter would be consistent with how we are doing input routing, i.e. grouping display and input devices to a seat for multiseat setups (see docs/multiseat.txt for more details). The consoles are already present in the qom tree as /backend/console[] nodes, and they have device + head children. So qom users can map console= to display=,head= and visa versa already. So from a functionality point of view it doesn't really matter, it is largely a matter of taste ... cheers, Gerd