qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eduardo Habkost <ehabkost@redhat.com>
To: qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>
Subject: [Qemu-devel] [PATCH v2 5/7] stubs: cocoa_display_init() stub
Date: Thu, 12 Nov 2015 17:02:16 -0200	[thread overview]
Message-ID: <1447354938-1575-6-git-send-email-ehabkost@redhat.com> (raw)
In-Reply-To: <1447354938-1575-1-git-send-email-ehabkost@redhat.com>

One less #ifdef in vl.c.

Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
Changes v1 -> v2:
* Move stub file to stubs/ui/
---
 stubs/ui/Makefile.objs |  1 +
 stubs/ui/cocoa.c       | 10 ++++++++++
 vl.c                   |  2 --
 3 files changed, 11 insertions(+), 2 deletions(-)
 create mode 100644 stubs/ui/cocoa.c

diff --git a/stubs/ui/Makefile.objs b/stubs/ui/Makefile.objs
index 2e4c924..ce9a0ce 100644
--- a/stubs/ui/Makefile.objs
+++ b/stubs/ui/Makefile.objs
@@ -1,3 +1,4 @@
 stub-obj-y += vnc.o
 stub-obj-y += curses.o
 stub-obj-y += sdl.o
+stub-obj-y += cocoa.o
diff --git a/stubs/ui/cocoa.c b/stubs/ui/cocoa.c
new file mode 100644
index 0000000..ef07a8a
--- /dev/null
+++ b/stubs/ui/cocoa.c
@@ -0,0 +1,10 @@
+#include "qemu-common.h"
+#include "ui/console.h"
+#include "qemu/error-report.h"
+
+void cocoa_display_init(DisplayState *ds, int full_screen)
+{
+    /* This must never be called if CONFIG_COCA is disabled */
+    error_report("Cocoa support is disabled");
+    abort();
+}
diff --git a/vl.c b/vl.c
index 5292648..ea83e17 100644
--- a/vl.c
+++ b/vl.c
@@ -4573,11 +4573,9 @@ int main(int argc, char **argv, char **envp)
     case DT_SDL:
         sdl_display_init(ds, full_screen, no_frame);
         break;
-#if defined(CONFIG_COCOA)
     case DT_COCOA:
         cocoa_display_init(ds, full_screen);
         break;
-#endif
 #if defined(CONFIG_GTK)
     case DT_GTK:
         gtk_display_init(ds, full_screen, grab_on_hover);
-- 
2.1.0

  parent reply	other threads:[~2015-11-12 19:02 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-12 19:02 [Qemu-devel] [PATCH v2 0/7] vl: graphics stubs + #ifdef cleanup Eduardo Habkost
2015-11-12 19:02 ` [Qemu-devel] [PATCH v2 1/7] vl: Add DT_COCOA DisplayType value Eduardo Habkost
2015-11-13 15:49   ` Andreas Färber
2015-11-12 19:02 ` [Qemu-devel] [PATCH v2 2/7] stubs: VNC initialization stubs Eduardo Habkost
2015-11-12 19:02 ` [Qemu-devel] [PATCH v2 3/7] stubs: curses_display_init() stub Eduardo Habkost
2015-11-12 19:02 ` [Qemu-devel] [PATCH v2 4/7] stubs: SDL initialization stubs Eduardo Habkost
2015-11-12 19:02 ` Eduardo Habkost [this message]
2015-11-17 14:45   ` [Qemu-devel] [PATCH v2 5/7] stubs: cocoa_display_init() stub Peter Maydell
2015-11-17 15:09     ` Eduardo Habkost
2015-11-12 19:02 ` [Qemu-devel] [PATCH v2 6/7] stubs: gtk_display_init() stub Eduardo Habkost
2015-11-12 19:02 ` [Qemu-devel] [PATCH v2 7/7] spice: Initialization stubs on qemu-spice.h Eduardo Habkost
2015-11-13  7:27   ` Gerd Hoffmann
2015-11-12 21:17 ` [Qemu-devel] [PATCH v2 0/7] vl: graphics stubs + #ifdef cleanup Eric Blake
2015-11-12 21:49   ` Eduardo Habkost
2015-11-13 18:28     ` Eduardo Habkost

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1447354938-1575-6-git-send-email-ehabkost@redhat.com \
    --to=ehabkost@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).