From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43047) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zx8HF-0008HZ-4v for qemu-devel@nongnu.org; Fri, 13 Nov 2015 01:56:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zx8HB-0008T1-4m for qemu-devel@nongnu.org; Fri, 13 Nov 2015 01:56:05 -0500 Received: from mx1.redhat.com ([209.132.183.28]:39434) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zx8HA-0008Sx-VV for qemu-devel@nongnu.org; Fri, 13 Nov 2015 01:56:01 -0500 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id 9AF55F5DD1 for ; Fri, 13 Nov 2015 06:56:00 +0000 (UTC) From: Bandan Das Date: Fri, 13 Nov 2015 01:55:48 -0500 Message-Id: <1447397748-24920-3-git-send-email-bsd@redhat.com> In-Reply-To: <1447397748-24920-1-git-send-email-bsd@redhat.com> References: <1447397748-24920-1-git-send-email-bsd@redhat.com> Subject: [Qemu-devel] [PATCH v3 2/2] i440fx: print an error message if user tries to enable iommu List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Bandan Das , armbru@redhat.com, mst@redhat.com There's no indication of any sort that i440fx doesn't support "iommu=on" Reviewed-by: Eric Blake Signed-off-by: Bandan Das --- hw/pci-host/piix.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/hw/pci-host/piix.c b/hw/pci-host/piix.c index 7b2fbf9..715208b 100644 --- a/hw/pci-host/piix.c +++ b/hw/pci-host/piix.c @@ -34,6 +34,7 @@ #include "sysemu/sysemu.h" #include "hw/i386/ioapic.h" #include "qapi/visitor.h" +#include "qemu/error-report.h" /* * I440FX chipset data sheet. @@ -301,6 +302,10 @@ static void i440fx_pcihost_realize(DeviceState *dev, Error **errp) static void i440fx_realize(PCIDevice *dev, Error **errp) { dev->config[I440FX_SMRAM] = 0x02; + + if (object_property_get_bool(qdev_get_machine(), "iommu", NULL)) { + error_report("warning: i440fx doesn't support emulated iommu"); + } } PCIBus *i440fx_init(const char *host_type, const char *pci_type, -- 2.5.0