From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48507) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zx8iS-0005yr-Bq for qemu-devel@nongnu.org; Fri, 13 Nov 2015 02:24:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zx8iN-0006sO-P2 for qemu-devel@nongnu.org; Fri, 13 Nov 2015 02:24:12 -0500 Received: from mga01.intel.com ([192.55.52.88]:49145) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zx8iN-0006r4-JM for qemu-devel@nongnu.org; Fri, 13 Nov 2015 02:24:07 -0500 From: Yuanhan Liu Date: Fri, 13 Nov 2015 15:24:10 +0800 Message-Id: <1447399450-29489-2-git-send-email-yuanhan.liu@linux.intel.com> In-Reply-To: <1447399450-29489-1-git-send-email-yuanhan.liu@linux.intel.com> References: <1447399450-29489-1-git-send-email-yuanhan.liu@linux.intel.com> Subject: [Qemu-devel] [PATCH 2/2] vhost: don't send RESET_OWNER at stop List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Yuanhan Liu , mst@redhat.com First of all, RESET_OWNER message is sent incorrectly, as it's sent before GET_VRING_BASE. And the reset message would let the later call get nothing correct. And, sending SET_VRING_ENABLE at stop, which has already been done, makes more sense than RESET_OWNER. Signed-off-by: Yuanhan Liu --- hw/net/vhost_net.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/hw/net/vhost_net.c b/hw/net/vhost_net.c index d91b7b1..14337a4 100644 --- a/hw/net/vhost_net.c +++ b/hw/net/vhost_net.c @@ -292,12 +292,6 @@ static void vhost_net_stop_one(struct vhost_net *net, int r = vhost_ops->vhost_net_set_backend(&net->dev, &file); assert(r >= 0); } - } else if (net->nc->info->type == NET_CLIENT_OPTIONS_KIND_VHOST_USER) { - for (file.index = 0; file.index < net->dev.nvqs; ++file.index) { - const VhostOps *vhost_ops = net->dev.vhost_ops; - int r = vhost_ops->vhost_reset_device(&net->dev); - assert(r >= 0); - } } if (net->nc->info->poll) { net->nc->info->poll(net->nc, true); -- 1.9.3