From: Gerd Hoffmann <kraxel@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-devel@nongnu.org, armbru@redhat.com
Subject: Re: [Qemu-devel] [PATCH for-2.5 v2] input: Document why x-input-send-event is still experimental
Date: Fri, 13 Nov 2015 08:25:22 +0100 [thread overview]
Message-ID: <1447399522.1400.71.camel@redhat.com> (raw)
In-Reply-To: <1447354243-31825-1-git-send-email-eblake@redhat.com>
On Do, 2015-11-12 at 11:50 -0700, Eric Blake wrote:
> The x-input-send-event command was introduced in 2.2 with mention
> that it is experimental, but now that several releases have elapsed
> without any changes, it would be nice to document why that was done
> and should still remain experimental in 2.5.
>
> Meanwhile, our documentation states that we prefer 'lower-case',
> rather than 'CamelCase', for qapi enum values. The InputButton and
> InputAxis enums violate this convention. However, because they are
> currently used primarily for generating code that is used internally;
> and their only exposure through QMP is via the experimental
> 'x-input-send-event' command, we are free to change their spelling.
> Of course, it would be nicer to delay such a change until the same
> time we promote the command to non-experimental. Adding
> documentation will help us remember to do that rename.
>
> We have plans to tighten the qapi generator to flag instances of
> inconsistent use of naming conventions; if that lands first, it
> will just need to whitelist these exceptions until the time we
> settle on the final interface.
Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>
next prev parent reply other threads:[~2015-11-13 7:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-12 18:50 [Qemu-devel] [PATCH for-2.5 v2] input: Document why x-input-send-event is still experimental Eric Blake
2015-11-13 7:25 ` Gerd Hoffmann [this message]
2015-11-13 9:05 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1447399522.1400.71.camel@redhat.com \
--to=kraxel@redhat.com \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).