* [Qemu-devel] [PATCH for-2.5] block: Call external_snapshot_clean after blockdev-snapshot
@ 2015-11-13 13:00 Alberto Garcia
2015-11-16 6:09 ` Fam Zheng
2015-11-16 20:23 ` Max Reitz
0 siblings, 2 replies; 3+ messages in thread
From: Alberto Garcia @ 2015-11-13 13:00 UTC (permalink / raw)
To: qemu-devel
Cc: Kevin Wolf, Alberto Garcia, qemu-block, Max Reitz,
Stefan Hajnoczi, Fam Zheng
Otherwise the AioContext will never be released.
Signed-off-by: Alberto Garcia <berto@igalia.com>
---
blockdev.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/blockdev.c b/blockdev.c
index fc85128..4dcc510 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -2070,6 +2070,7 @@ static const BlkActionOps actions[] = {
.prepare = external_snapshot_prepare,
.commit = external_snapshot_commit,
.abort = external_snapshot_abort,
+ .clean = external_snapshot_clean,
},
[TRANSACTION_ACTION_KIND_BLOCKDEV_SNAPSHOT_SYNC] = {
.instance_size = sizeof(ExternalSnapshotState),
--
2.6.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH for-2.5] block: Call external_snapshot_clean after blockdev-snapshot
2015-11-13 13:00 [Qemu-devel] [PATCH for-2.5] block: Call external_snapshot_clean after blockdev-snapshot Alberto Garcia
@ 2015-11-16 6:09 ` Fam Zheng
2015-11-16 20:23 ` Max Reitz
1 sibling, 0 replies; 3+ messages in thread
From: Fam Zheng @ 2015-11-16 6:09 UTC (permalink / raw)
To: Alberto Garcia
Cc: Kevin Wolf, Stefan Hajnoczi, qemu-devel, qemu-block, Max Reitz
On Fri, 11/13 15:00, Alberto Garcia wrote:
> Otherwise the AioContext will never be released.
>
> Signed-off-by: Alberto Garcia <berto@igalia.com>
> ---
> blockdev.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/blockdev.c b/blockdev.c
> index fc85128..4dcc510 100644
> --- a/blockdev.c
> +++ b/blockdev.c
> @@ -2070,6 +2070,7 @@ static const BlkActionOps actions[] = {
> .prepare = external_snapshot_prepare,
> .commit = external_snapshot_commit,
> .abort = external_snapshot_abort,
> + .clean = external_snapshot_clean,
> },
> [TRANSACTION_ACTION_KIND_BLOCKDEV_SNAPSHOT_SYNC] = {
> .instance_size = sizeof(ExternalSnapshotState),
> --
> 2.6.2
>
Reviewed-by: Fam Zheng <famz@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH for-2.5] block: Call external_snapshot_clean after blockdev-snapshot
2015-11-13 13:00 [Qemu-devel] [PATCH for-2.5] block: Call external_snapshot_clean after blockdev-snapshot Alberto Garcia
2015-11-16 6:09 ` Fam Zheng
@ 2015-11-16 20:23 ` Max Reitz
1 sibling, 0 replies; 3+ messages in thread
From: Max Reitz @ 2015-11-16 20:23 UTC (permalink / raw)
To: Alberto Garcia, qemu-devel
Cc: Kevin Wolf, Fam Zheng, Stefan Hajnoczi, qemu-block
[-- Attachment #1: Type: text/plain, Size: 819 bytes --]
On 13.11.2015 14:00, Alberto Garcia wrote:
> Otherwise the AioContext will never be released.
>
> Signed-off-by: Alberto Garcia <berto@igalia.com>
> ---
> blockdev.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/blockdev.c b/blockdev.c
> index fc85128..4dcc510 100644
> --- a/blockdev.c
> +++ b/blockdev.c
> @@ -2070,6 +2070,7 @@ static const BlkActionOps actions[] = {
> .prepare = external_snapshot_prepare,
> .commit = external_snapshot_commit,
> .abort = external_snapshot_abort,
> + .clean = external_snapshot_clean,
> },
> [TRANSACTION_ACTION_KIND_BLOCKDEV_SNAPSHOT_SYNC] = {
> .instance_size = sizeof(ExternalSnapshotState),
Thanks, applied to my block tree:
https://github.com/XanClic/qemu/commits/block
Max
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-11-16 20:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-13 13:00 [Qemu-devel] [PATCH for-2.5] block: Call external_snapshot_clean after blockdev-snapshot Alberto Garcia
2015-11-16 6:09 ` Fam Zheng
2015-11-16 20:23 ` Max Reitz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).