From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49770)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <prvs=7522a583b=Ian.Campbell@citrix.com>)
	id 1ZxEor-0008UO-PK
	for qemu-devel@nongnu.org; Fri, 13 Nov 2015 08:55:14 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <prvs=7522a583b=Ian.Campbell@citrix.com>)
	id 1ZxEoo-0003Ro-IY
	for qemu-devel@nongnu.org; Fri, 13 Nov 2015 08:55:13 -0500
Received: from smtp02.citrix.com ([66.165.176.63]:28184)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <prvs=7522a583b=Ian.Campbell@citrix.com>)
	id 1ZxEoo-0003Ra-E3
	for qemu-devel@nongnu.org; Fri, 13 Nov 2015 08:55:10 -0500
Message-ID: <1447422889.18450.135.camel@citrix.com>
From: Ian Campbell <ian.campbell@citrix.com>
Date: Fri, 13 Nov 2015 13:54:49 +0000
In-Reply-To: <alpine.DEB.2.02.1511131333180.2653@kaball.uk.xensource.com>
References: <alpine.DEB.2.02.1511131108080.526@kaball.uk.xensource.com>
	<1447417100-24921-1-git-send-email-roger.pau@citrix.com>
	<alpine.DEB.2.02.1511131333180.2653@kaball.uk.xensource.com>
Content-Type: text/plain; charset="UTF-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH QEMU v2 2/2] xen: fix usage of
 xc_domain_create in domain builder
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>, Roger Pau Monne <roger.pau@citrix.com>
Cc: xen-devel@lists.xenproject.org, qemu-devel@nongnu.org

On Fri, 2015-11-13 at 13:46 +0000, Stefano Stabellini wrote:
> On Fri, 13 Nov 2015, Roger Pau Monne wrote:
> > Due to the addition of HVMlite and the requirement to always provide a
> > valid
> > xc_domain_configuration_t, xc_domain_create now always takes an arch
> > domain
> > config, which can be NULL in order to mimic previous behaviour.
> >=20
> > Add a small stub called xen_domain_create that encapsulates the correct
> > call
> > to xc_domain_create depending on the libxc version detected.
> >=20
> > Signed-off-by: Roger Pau Monn=C3=A9 <roger.pau@citrix.com>
>=20
> FYI this is going to conflict with Ian's series:
>=20
> 1447070487-31229-1-git-send-email-ian.campbell@citrix.com

The bit being patched here is disabled by
"xen: make it possible to build without the Xen PV domain builder" in that
series.

In any case I think Roger's stuff would be better off going in first and I
can easily rebase over it.

> In addition, the patch causes a build failure against most Xen versions:
>=20
> In file included from
> /local/scratch/sstabellini/qemu/include/hw/xen/xen_backend.h:4:0,
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0from hw/block/xen_disk.c:38:
> /local/scratch/sstabellini/qemu/include/hw/xen/xen_common.h:445:37:
> error: unknown type name =E2=80=98xc_domain_configuration_t=E2=80=99
> =C2=A0 CC=C2=A0=C2=A0=C2=A0=C2=A0hw/bt/hci-csr.o
> make: *** [hw/block/xen_disk.o] Error 1

Given the only caller today passes NULL I'd suggest moving the NULL down
into the wrapper, i.e. dropping the argument from xen_domain_create.

If someone wants to resurrect the domain build in QEMU _and_ teach it to do
pvh, then they will surely be able to refactor this to suit their needs.

Ian.