qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Denis V. Lunev" <den@openvz.org>
Cc: Juan Quintela <quintela@redhat.com>,
	qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>,
	Amit Shah <amit.shah@redhat.com>,
	"Denis V. Lunev" <den@openvz.org>
Subject: [Qemu-devel] [PATCH 0/5] QMP wrappers for VM snapshot operations
Date: Mon, 16 Nov 2015 18:32:25 +0300	[thread overview]
Message-ID: <1447687950-29350-1-git-send-email-den@openvz.org> (raw)

EFI based VM with pflash storage for NVRAM could not be snapshoted as
libvirt configures storage as 'raw' and writable. OK, this is a libvirt
problem.

Another problem is that libvirt can not detect this failure at all
as it uses HMP for this operation. This create snapshot/delete snapshot
sequence passes silently.

The patchset adds QMP wrappers for the purpose.

At the moment I have placed 2.6 version into QAPI. Though (if you feel
appropriate) I can change it to 2.5 :) This is up to you to decide.

Please note, this patchset is made on top of
  [PATCH for 2.5 v8 0/10] dataplane snapshot fixes

Signed-off-by: "Denis V. Lunev" <den@openvz.org>
CC: Juan Quintela <quintela@redhat.com>
CC: Amit Shah <amit.shah@redhat.com>
CC: Markus Armbruster <armbru@redhat.com>
CC: Eric Blake <eblake@redhat.com>

Denis V. Lunev (5):
  migration: split hmp_savevm to do_savevm and hmp_savevm wrapper
  qmp: create qmp_savevm command
  qmp: create qmp_delvm command
  migration: improve error reporting for hmp_loadvm
  qmp: create QMP implementation of loadvm command

 include/sysemu/sysemu.h |   2 +-
 migration/savevm.c      | 100 +++++++++++++++++++++++++++++++-----------------
 monitor.c               |   7 +++-
 qapi-schema.json        |  39 +++++++++++++++++++
 qmp-commands.hx         |  71 ++++++++++++++++++++++++++++++++++
 vl.c                    |   5 ++-
 6 files changed, 185 insertions(+), 39 deletions(-)

-- 
2.5.0

             reply	other threads:[~2015-11-16 15:32 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-16 15:32 Denis V. Lunev [this message]
2015-11-16 15:32 ` [Qemu-devel] [PATCH 1/5] migration: split hmp_savevm to do_savevm and hmp_savevm wrapper Denis V. Lunev
2015-11-17  8:56   ` Markus Armbruster
2015-11-18 11:29   ` Juan Quintela
2015-11-16 15:32 ` [Qemu-devel] [PATCH 2/5] qmp: create qmp_savevm command Denis V. Lunev
2015-11-17 10:10   ` Markus Armbruster
2015-11-18 11:36     ` Juan Quintela
2015-12-01 14:28       ` Denis V. Lunev
2015-12-01 15:01         ` Eric Blake
2015-12-01 15:03         ` Markus Armbruster
2015-12-01 14:29     ` Denis V. Lunev
2015-12-01 15:05       ` Markus Armbruster
2015-12-01 15:18         ` Denis V. Lunev
2015-11-16 15:32 ` [Qemu-devel] [PATCH 3/5] qmp: create qmp_delvm command Denis V. Lunev
2015-11-17 10:14   ` Markus Armbruster
2015-11-18 11:37     ` Juan Quintela
2015-11-18 11:37   ` Juan Quintela
2015-11-16 15:32 ` [Qemu-devel] [PATCH 4/5] migration: improve error reporting for hmp_loadvm Denis V. Lunev
2015-11-17 10:34   ` Markus Armbruster
2015-11-16 15:32 ` [Qemu-devel] [PATCH 5/5] qmp: create QMP implementation of loadvm command Denis V. Lunev
2015-11-18 11:41   ` Juan Quintela
2015-12-01 15:19     ` Denis V. Lunev
2015-11-17 10:33 ` [Qemu-devel] [PATCH 0/5] QMP wrappers for VM snapshot operations Markus Armbruster
2015-11-17 10:44   ` Denis V. Lunev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1447687950-29350-1-git-send-email-den@openvz.org \
    --to=den@openvz.org \
    --cc=amit.shah@redhat.com \
    --cc=armbru@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).