qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Alex Williamson <alex.williamson@redhat.com>
To: Chen Fan <chen.fan.fnst@cn.fujitsu.com>
Cc: Cao jin <caoj.fnst@cn.fujitsu.com>,
	qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v13 09/13] add check reset mechanism when hotplug vfio device
Date: Mon, 16 Nov 2015 09:05:37 -0700	[thread overview]
Message-ID: <1447689937.3946.243.camel@redhat.com> (raw)
In-Reply-To: <5649AD5F.6020407@cn.fujitsu.com>

On Mon, 2015-11-16 at 18:18 +0800, Chen Fan wrote:
> Hi Alex,
> 
>    Thanks for your detailed explanation.
>    during my test, I found that maybe there was another problem in vfio 
> driver,
> I use a dual-port NIC which address are: 06:00.0 and 06:00.1 two functions.
> then I use aer-inject to inject one error to one function like following:
> AER
> ID 0000:06:00.0
> UNCOR_STATUS DLP
> HEADER_LOG 0 1 2 3
> 
> here I boot qemu with one enable aer, one disable aer:
> ./x86_64-softmmu/qemu-system-x86_64 -M q35 -device 
> ioh3420,bus=pcie.0,addr=1c.0,port=1,id=bridge1,chassis=1
>   -device vfio-pci,host=06:00.1,bus=bridge1,addr=00.1
>   -device 
> vfio-pci,host=06:00.0,bus=bridge1,addr=00.0,aer=true,multifunction=on
> 
> so we expected that the error only sent to the vfio device with host 
> address is 06:00.0,
> but I found that all devices (06:00.0 , 06:00.1) receive the signal in 
> qemu, which sent by vfio driver
> in vfio_pci_aer_err_detected. then qemu stopped by the device with 
> 06:00.1 received the signal.
> is that right?

You would need to know whether the response for the injected AER affects
all devices on the link or is isolated to the function specified.  VFIO
is just a passthrough for pci_error_handlers, so if error_detected is
getting called for each host device, it's going to signal each device to
the user.  Thanks,

Alex

  reply	other threads:[~2015-11-16 16:05 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-11 10:34 [Qemu-devel] [PATCH v13 00/13] vfio-pci: pass the aer error to guest Cao jin
2015-11-11 10:34 ` [Qemu-devel] [PATCH v13 01/13] vfio: extract vfio_get_hot_reset_info as a single function Cao jin
2015-11-11 10:34 ` [Qemu-devel] [PATCH v13 02/13] vfio: squeeze out vfio_pci_do_hot_reset for support bus reset Cao jin
2015-11-11 10:34 ` [Qemu-devel] [PATCH v13 03/13] pcie: modify the capability size assert Cao jin
2015-11-11 16:55   ` Michael S. Tsirkin
2015-11-11 10:34 ` [Qemu-devel] [PATCH v13 04/13] vfio: make the 4 bytes aligned for capability size Cao jin
2015-11-11 10:34 ` [Qemu-devel] [PATCH v13 05/13] vfio: add pcie extanded capability support Cao jin
2015-11-11 10:34 ` [Qemu-devel] [PATCH v13 06/13] aer: impove pcie_aer_init to support vfio device Cao jin
2015-11-11 16:55   ` Michael S. Tsirkin
2015-11-11 10:34 ` [Qemu-devel] [PATCH v13 07/13] vfio: add aer support for " Cao jin
2015-11-11 20:49   ` Alex Williamson
2015-11-12 11:54     ` Cao jin
2015-11-11 10:34 ` [Qemu-devel] [PATCH v13 08/13] vfio: add check host bus reset is support or not Cao jin
2015-11-11 20:53   ` Alex Williamson
2015-11-12 11:56     ` Cao jin
2015-11-11 10:34 ` [Qemu-devel] [PATCH v13 09/13] add check reset mechanism when hotplug vfio device Cao jin
2015-11-12 11:51   ` Michael S. Tsirkin
2015-11-13  3:28     ` Cao jin
2015-11-13 21:04       ` Alex Williamson
2015-11-16 10:18         ` Chen Fan
2015-11-16 16:05           ` Alex Williamson [this message]
2015-11-17  2:48             ` Chen Fan
2015-11-11 10:34 ` [Qemu-devel] [PATCH v13 10/13] pci: add pci device pre-post reset callbacks for host bus reset Cao jin
2015-11-11 16:56   ` Michael S. Tsirkin
2015-11-11 20:58   ` Alex Williamson
2015-11-12 11:58     ` Cao jin
2015-11-11 10:34 ` [Qemu-devel] [PATCH v13 11/13] pcie_aer: expose pcie_aer_msg() interface Cao jin
2015-11-11 16:56   ` Michael S. Tsirkin
2015-11-11 10:34 ` [Qemu-devel] [PATCH v13 12/13] vfio-pci: pass the aer error to guest Cao jin
2015-11-11 10:34 ` [Qemu-devel] [PATCH v13 13/13] vfio: add 'aer' property to expose aercap Cao jin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1447689937.3946.243.camel@redhat.com \
    --to=alex.williamson@redhat.com \
    --cc=caoj.fnst@cn.fujitsu.com \
    --cc=chen.fan.fnst@cn.fujitsu.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).