From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45381) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZyMqi-00063h-BN for qemu-devel@nongnu.org; Mon, 16 Nov 2015 11:41:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZyMqe-0004gA-W8 for qemu-devel@nongnu.org; Mon, 16 Nov 2015 11:41:48 -0500 Received: from mx1.redhat.com ([209.132.183.28]:41280) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZyMqe-0004fb-R2 for qemu-devel@nongnu.org; Mon, 16 Nov 2015 11:41:44 -0500 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id D0B51C0A147A for ; Mon, 16 Nov 2015 16:41:43 +0000 (UTC) Received: from redhat.com (ovpn-116-46.ams2.redhat.com [10.36.116.46]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with SMTP id tAGGfeKV009818 for ; Mon, 16 Nov 2015 11:41:40 -0500 Date: Mon, 16 Nov 2015 18:41:39 +0200 From: "Michael S. Tsirkin" Message-ID: <1447692089-16849-1-git-send-email-mst@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Subject: [Qemu-devel] [PATCH] vhost-user: start/stop all rings List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org We are currently only sending VRING_ENABLE message for the first ring, that's wrong: we must start/stop them all. Signed-off-by: Michael S. Tsirkin --- hw/virtio/vhost-user.c | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c index 5bc6c45..dab6b41 100644 --- a/hw/virtio/vhost-user.c +++ b/hw/virtio/vhost-user.c @@ -333,18 +333,23 @@ static int vhost_user_set_vring_base(struct vhost_dev *dev, static int vhost_user_set_vring_enable(struct vhost_dev *dev, int enable) { - struct vhost_vring_state state = { - .index = dev->vq_index, - .num = enable, - }; + int i; if (!virtio_has_feature(dev->features, VHOST_USER_F_PROTOCOL_FEATURES)) { return -1; } - return vhost_set_vring(dev, VHOST_USER_SET_VRING_ENABLE, &state); -} + for (i = 0; i < dev->nvq; ++i) { + struct vhost_vring_state state = { + .index = dev->vq_index + i, + .num = enable, + }; + + vhost_set_vring(dev, VHOST_USER_SET_VRING_ENABLE, &state); + } + return 0; +} static int vhost_user_get_vring_base(struct vhost_dev *dev, struct vhost_vring_state *ring) -- MST