qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: Gerd Hoffmann <kraxel@redhat.com>
Subject: [Qemu-devel] [PULL 08/20] vnc: kill jobs queue buffer
Date: Mon, 16 Nov 2015 18:25:23 +0100	[thread overview]
Message-ID: <1447694735-3420-9-git-send-email-kraxel@redhat.com> (raw)
In-Reply-To: <1447694735-3420-1-git-send-email-kraxel@redhat.com>

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Peter Lieven <pl@kamp.de>
Reviewed-by: Daniel P. Berrange <berrange@redhat.com>
Message-id: 1446203414-4013-9-git-send-email-kraxel@redhat.com
---
 ui/vnc-jobs.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/ui/vnc-jobs.c b/ui/vnc-jobs.c
index 2e6c15f..329d13e 100644
--- a/ui/vnc-jobs.c
+++ b/ui/vnc-jobs.c
@@ -54,7 +54,6 @@ struct VncJobQueue {
     QemuCond cond;
     QemuMutex mutex;
     QemuThread thread;
-    Buffer buffer;
     bool exit;
     QTAILQ_HEAD(, VncJob) jobs;
 };
@@ -193,7 +192,6 @@ static void vnc_async_encoding_start(VncState *orig, VncState *local)
     local->zlib = orig->zlib;
     local->hextile = orig->hextile;
     local->zrle = orig->zrle;
-    local->output =  queue->buffer;
     local->csock = -1; /* Don't do any network work on this thread */
 
     buffer_reset(&local->output);
@@ -206,8 +204,6 @@ static void vnc_async_encoding_end(VncState *orig, VncState *local)
     orig->hextile = local->hextile;
     orig->zrle = local->zrle;
     orig->lossy_rect = local->lossy_rect;
-
-    queue->buffer = local->output;
 }
 
 static int vnc_worker_thread_loop(VncJobQueue *queue)
@@ -304,7 +300,6 @@ static VncJobQueue *vnc_queue_init(void)
 
     qemu_cond_init(&queue->cond);
     qemu_mutex_init(&queue->mutex);
-    buffer_init(&queue->buffer, "vnc-job-queue");
     QTAILQ_INIT(&queue->jobs);
     return queue;
 }
@@ -313,7 +308,6 @@ static void vnc_queue_clear(VncJobQueue *q)
 {
     qemu_cond_destroy(&queue->cond);
     qemu_mutex_destroy(&queue->mutex);
-    buffer_free(&queue->buffer);
     g_free(q);
     queue = NULL; /* Unset global queue */
 }
-- 
1.8.3.1

  parent reply	other threads:[~2015-11-16 17:25 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-16 17:25 [Qemu-devel] [PULL for-2.5 00/20] vnc: buffer code improvements, bugfixes Gerd Hoffmann
2015-11-16 17:25 ` [Qemu-devel] [PULL 01/20] buffer: make the Buffer capacity increase in powers of two Gerd Hoffmann
2015-11-16 17:25 ` [Qemu-devel] [PULL 02/20] buffer: add buffer_init Gerd Hoffmann
2015-11-16 17:25 ` [Qemu-devel] [PULL 03/20] buffer: add buffer_move_empty Gerd Hoffmann
2015-11-16 17:25 ` [Qemu-devel] [PULL 04/20] buffer: add buffer_move Gerd Hoffmann
2015-11-16 17:25 ` [Qemu-devel] [PULL 05/20] buffer: add buffer_shrink Gerd Hoffmann
2015-11-16 17:25 ` [Qemu-devel] [PULL 06/20] buffer: add tracing Gerd Hoffmann
2015-11-16 17:25 ` [Qemu-devel] [PULL 07/20] vnc: attach names to buffers Gerd Hoffmann
2015-11-16 17:25 ` Gerd Hoffmann [this message]
2015-11-16 17:25 ` [Qemu-devel] [PULL 09/20] vnc-jobs: move buffer reset, use new buffer move Gerd Hoffmann
2015-11-16 17:25 ` [Qemu-devel] [PULL 10/20] vnc: zap dead code Gerd Hoffmann
2015-11-16 17:25 ` [Qemu-devel] [PULL 11/20] vnc: add vnc_width+vnc_height helpers Gerd Hoffmann
2015-11-16 17:25 ` [Qemu-devel] [PULL 12/20] vnc: factor out vnc_update_server_surface Gerd Hoffmann
2015-11-16 17:25 ` [Qemu-devel] [PULL 13/20] vnc: use vnc_{width, height} in vnc_set_area_dirty Gerd Hoffmann
2015-11-16 17:25 ` [Qemu-devel] [PULL 14/20] vnc: only alloc server surface with clients connected Gerd Hoffmann
2015-11-16 17:25 ` [Qemu-devel] [PULL 15/20] vnc: fix local state init Gerd Hoffmann
2015-11-16 17:25 ` [Qemu-devel] [PULL 16/20] vnc: recycle empty vs->output buffer Gerd Hoffmann
2015-11-16 17:25 ` [Qemu-devel] [PULL 17/20] buffer: factor out buffer_req_size Gerd Hoffmann
2015-11-16 17:25 ` [Qemu-devel] [PULL 18/20] buffer: factor out buffer_adj_size Gerd Hoffmann
2015-11-16 17:25 ` [Qemu-devel] [PULL 19/20] buffer: allow a buffer to shrink gracefully Gerd Hoffmann
2015-11-16 17:25 ` [Qemu-devel] [PULL 20/20] vnc: fix mismerge Gerd Hoffmann
2015-11-17 16:32 ` [Qemu-devel] [PULL for-2.5 00/20] vnc: buffer code improvements, bugfixes Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1447694735-3420-9-git-send-email-kraxel@redhat.com \
    --to=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).