From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: [Qemu-devel] [PULL for-2.5 3/7] tpm: avoid clang shifting negative signed warning
Date: Tue, 17 Nov 2015 19:17:24 +0800 [thread overview]
Message-ID: <1447759048-25772-4-git-send-email-stefanha@redhat.com> (raw)
In-Reply-To: <1447759048-25772-1-git-send-email-stefanha@redhat.com>
clang 3.7.0 on x86_64 warns about the following:
hw/tpm/tpm_tis.c:1000:36: warning: shifting a negative signed value is undefined [-Wshift-negative-value]
tis->loc[c].iface_id = TPM_TIS_IFACE_ID_SUPPORTED_FLAGS1_3;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
hw/tpm/tpm_tis.c:144:10: note: expanded from macro 'TPM_TIS_IFACE_ID_SUPPORTED_FLAGS1_3'
(~0 << 4)/* all of it is don't care */)
~~ ^
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
hw/tpm/tpm_tis.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/tpm/tpm_tis.c b/hw/tpm/tpm_tis.c
index 0806b5f..ff073d5 100644
--- a/hw/tpm/tpm_tis.c
+++ b/hw/tpm/tpm_tis.c
@@ -141,7 +141,7 @@
#define TPM_TIS_IFACE_ID_SUPPORTED_FLAGS1_3 \
(TPM_TIS_IFACE_ID_INTERFACE_TIS1_3 | \
- (~0 << 4)/* all of it is don't care */)
+ (~0u << 4)/* all of it is don't care */)
/* if backend was a TPM 2.0: */
#define TPM_TIS_IFACE_ID_SUPPORTED_FLAGS2_0 \
--
2.5.0
next prev parent reply other threads:[~2015-11-17 11:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-17 11:17 [Qemu-devel] [PULL for-2.5 0/7] Block patches Stefan Hajnoczi
2015-11-17 11:17 ` [Qemu-devel] [PULL for-2.5 1/7] docs: update bitmaps.md Stefan Hajnoczi
2015-11-17 11:17 ` [Qemu-devel] [PULL for-2.5 2/7] tests: Ignore recent test binaries Stefan Hajnoczi
2015-11-17 11:17 ` Stefan Hajnoczi [this message]
2015-11-17 11:17 ` [Qemu-devel] [PULL for-2.5 4/7] disas/arm: avoid clang shifting negative signed warning Stefan Hajnoczi
2015-11-17 11:17 ` [Qemu-devel] [PULL for-2.5 5/7] aio-epoll: Fix use-after-free of node Stefan Hajnoczi
2015-11-17 11:17 ` [Qemu-devel] [PULL for-2.5 6/7] block: make 'stats-interval' an array of ints instead of a string Stefan Hajnoczi
2015-11-17 11:17 ` [Qemu-devel] [PULL for-2.5 7/7] virtio-blk: Fix double completion for werror=stop Stefan Hajnoczi
2015-11-17 12:33 ` [Qemu-devel] [PULL for-2.5 0/7] Block patches Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1447759048-25772-4-git-send-email-stefanha@redhat.com \
--to=stefanha@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).