From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36467) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZyeGs-0004li-0x for qemu-devel@nongnu.org; Tue, 17 Nov 2015 06:17:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZyeGr-0003Rl-7i for qemu-devel@nongnu.org; Tue, 17 Nov 2015 06:17:57 -0500 Received: from mx1.redhat.com ([209.132.183.28]:53334) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZyeGr-0003Rh-2T for qemu-devel@nongnu.org; Tue, 17 Nov 2015 06:17:57 -0500 From: Stefan Hajnoczi Date: Tue, 17 Nov 2015 19:17:24 +0800 Message-Id: <1447759048-25772-4-git-send-email-stefanha@redhat.com> In-Reply-To: <1447759048-25772-1-git-send-email-stefanha@redhat.com> References: <1447759048-25772-1-git-send-email-stefanha@redhat.com> Subject: [Qemu-devel] [PULL for-2.5 3/7] tpm: avoid clang shifting negative signed warning List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Peter Maydell , Stefan Hajnoczi clang 3.7.0 on x86_64 warns about the following: hw/tpm/tpm_tis.c:1000:36: warning: shifting a negative signed value is undefined [-Wshift-negative-value] tis->loc[c].iface_id = TPM_TIS_IFACE_ID_SUPPORTED_FLAGS1_3; ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ hw/tpm/tpm_tis.c:144:10: note: expanded from macro 'TPM_TIS_IFACE_ID_SUPPORTED_FLAGS1_3' (~0 << 4)/* all of it is don't care */) ~~ ^ Signed-off-by: Stefan Hajnoczi --- hw/tpm/tpm_tis.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/tpm/tpm_tis.c b/hw/tpm/tpm_tis.c index 0806b5f..ff073d5 100644 --- a/hw/tpm/tpm_tis.c +++ b/hw/tpm/tpm_tis.c @@ -141,7 +141,7 @@ #define TPM_TIS_IFACE_ID_SUPPORTED_FLAGS1_3 \ (TPM_TIS_IFACE_ID_INTERFACE_TIS1_3 | \ - (~0 << 4)/* all of it is don't care */) + (~0u << 4)/* all of it is don't care */) /* if backend was a TPM 2.0: */ #define TPM_TIS_IFACE_ID_SUPPORTED_FLAGS2_0 \ -- 2.5.0