From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53611)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1Zywef-0000vC-9L
	for qemu-devel@nongnu.org; Wed, 18 Nov 2015 01:55:46 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1Zywec-0003Zb-1m
	for qemu-devel@nongnu.org; Wed, 18 Nov 2015 01:55:45 -0500
Received: from mx1.redhat.com ([209.132.183.28]:46222)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1Zyweb-0003ZN-OL
	for qemu-devel@nongnu.org; Wed, 18 Nov 2015 01:55:41 -0500
Received: from int-mx14.intmail.prod.int.phx2.redhat.com
	(int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27])
	by mx1.redhat.com (Postfix) with ESMTPS id CA3F0155DE
	for <qemu-devel@nongnu.org>; Wed, 18 Nov 2015 06:55:40 +0000 (UTC)
Message-ID: <1447829738.23726.83.camel@redhat.com>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Wed, 18 Nov 2015 07:55:38 +0100
In-Reply-To: <jpgk2pgchms.fsf@linux.bootlegged.copy>
References: <1447718794-19812-1-git-send-email-bsd@redhat.com>
	<1447718794-19812-4-git-send-email-bsd@redhat.com>
	<1447761819.23726.74.camel@redhat.com>
	<jpgk2pgchms.fsf@linux.bootlegged.copy>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3 3/4] usb-mtp: Add support for inotify
 based file monitoring
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Bandan Das <bsd@redhat.com>
Cc: qemu-devel@nongnu.org

  Hi,

> >> -    QLIST_FOREACH(iter, &o->children, list) {
> >> +    QLIST_FOREACH_SAFE(iter, &o->children, list, next) {
> >>          handles[i++] = iter->handle;
> >>      }
> >
> > No need for SAFE here, you don't change the list.
> 
> Isn't the SAFE variant better for the case where a inotify delete event occurs
> when we are getting the object handles ?

Device emulation runs under lock, therefore all serialized, so the
inotify event processing will not run in parallel.

cheers,
  Gerd