From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46835) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zz1EI-0002kd-NX for qemu-devel@nongnu.org; Wed, 18 Nov 2015 06:48:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zz1EE-0007Av-Vh for qemu-devel@nongnu.org; Wed, 18 Nov 2015 06:48:50 -0500 Received: from mx1.redhat.com ([209.132.183.28]:33873) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zz1EE-0007Ac-N3 for qemu-devel@nongnu.org; Wed, 18 Nov 2015 06:48:46 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id 1EC088E68D for ; Wed, 18 Nov 2015 11:48:46 +0000 (UTC) From: "Dr. David Alan Gilbert (git)" Date: Wed, 18 Nov 2015 11:48:40 +0000 Message-Id: <1447847321-20132-3-git-send-email-dgilbert@redhat.com> In-Reply-To: <1447847321-20132-1-git-send-email-dgilbert@redhat.com> References: <1447847321-20132-1-git-send-email-dgilbert@redhat.com> Subject: [Qemu-devel] [PATCH 2/3] migration: Dead assignment of current_time List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, quintela@redhat.com, amit.shah@redhat.com Cc: pbonzini@redhat.com From: "Dr. David Alan Gilbert" I set current_time before the postcopy test but never use it; (I think this was from the original version where it was time based). Spotted by coverity, CID 1339208 Signed-off-by: Dr. David Alan Gilbert --- migration/migration.c | 1 - 1 file changed, 1 deletion(-) diff --git a/migration/migration.c b/migration/migration.c index 7e4e27b..265d13a 100644 --- a/migration/migration.c +++ b/migration/migration.c @@ -1643,7 +1643,6 @@ static void *migration_thread(void *opaque) if (pending_size && pending_size >= max_size) { /* Still a significant amount to transfer */ - current_time = qemu_clock_get_ms(QEMU_CLOCK_REALTIME); if (migrate_postcopy_ram() && s->state != MIGRATION_STATUS_POSTCOPY_ACTIVE && pend_nonpost <= max_size && -- 2.5.0