From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58767) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zz4xd-0005KN-HE for qemu-devel@nongnu.org; Wed, 18 Nov 2015 10:47:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zz4xb-0001YU-CH for qemu-devel@nongnu.org; Wed, 18 Nov 2015 10:47:53 -0500 Received: from mx1.redhat.com ([209.132.183.28]:41227) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zz4xb-0001YQ-6U for qemu-devel@nongnu.org; Wed, 18 Nov 2015 10:47:51 -0500 From: "Daniel P. Berrange" Date: Wed, 18 Nov 2015 15:47:41 +0000 Message-Id: <1447861664-16283-2-git-send-email-berrange@redhat.com> In-Reply-To: <1447861664-16283-1-git-send-email-berrange@redhat.com> References: <1447861664-16283-1-git-send-email-berrange@redhat.com> Subject: [Qemu-devel] [PULL v1 (for 2.5) 1/4] crypto: fix leak of gnutls_dh_params_t data on credential unload List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Peter Maydell The QCryptoTLSCredsX509 object was not free'ing the allocated gnutls_dh_params_t data when unloading the credentials Signed-off-by: Daniel P. Berrange --- crypto/tlscredsx509.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/crypto/tlscredsx509.c b/crypto/tlscredsx509.c index dc46bc4..c5d1a0d 100644 --- a/crypto/tlscredsx509.c +++ b/crypto/tlscredsx509.c @@ -654,6 +654,10 @@ qcrypto_tls_creds_x509_unload(QCryptoTLSCredsX509 *creds) gnutls_certificate_free_credentials(creds->data); creds->data = NULL; } + if (creds->parent_obj.dh_params) { + gnutls_dh_params_deinit(creds->parent_obj.dh_params); + creds->parent_obj.dh_params = NULL; + } } -- 2.5.0