From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58790) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zz4xe-0005Li-To for qemu-devel@nongnu.org; Wed, 18 Nov 2015 10:47:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zz4xe-0001ZZ-00 for qemu-devel@nongnu.org; Wed, 18 Nov 2015 10:47:54 -0500 Received: from mx1.redhat.com ([209.132.183.28]:39982) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zz4xd-0001ZP-Mc for qemu-devel@nongnu.org; Wed, 18 Nov 2015 10:47:53 -0500 From: "Daniel P. Berrange" Date: Wed, 18 Nov 2015 15:47:43 +0000 Message-Id: <1447861664-16283-4-git-send-email-berrange@redhat.com> In-Reply-To: <1447861664-16283-1-git-send-email-berrange@redhat.com> References: <1447861664-16283-1-git-send-email-berrange@redhat.com> Subject: [Qemu-devel] [PULL v1 (for 2.5) 3/4] crypto: fix leaks in TLS x509 helper functions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Peter Maydell The test_tls_get_ipaddr() method forgot to free the returned data from getaddrinfo(). The test_tls_write_cert_chain() method forgot to free the allocated buffer holding the certificate data after writing it out to a file. Signed-off-by: Daniel P. Berrange --- tests/crypto-tls-x509-helpers.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/crypto-tls-x509-helpers.c b/tests/crypto-tls-x509-helpers.c index c5de67b..47b4c7b 100644 --- a/tests/crypto-tls-x509-helpers.c +++ b/tests/crypto-tls-x509-helpers.c @@ -153,6 +153,7 @@ test_tls_get_ipaddr(const char *addrstr, *datalen = res->ai_addrlen; *data = g_new(char, *datalen); memcpy(*data, res->ai_addr, *datalen); + freeaddrinfo(res); } /* @@ -465,6 +466,7 @@ void test_tls_write_cert_chain(const char *filename, if (!g_file_set_contents(filename, buffer, offset, NULL)) { abort(); } + g_free(buffer); } -- 2.5.0