qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: qemu-block@nongnu.org
Cc: kwolf@redhat.com, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PULL 3/4] blockdev: Add missing bdrv_unref() in drive-backup
Date: Wed, 18 Nov 2015 17:09:02 +0100	[thread overview]
Message-ID: <1447862943-16071-4-git-send-email-kwolf@redhat.com> (raw)
In-Reply-To: <1447862943-16071-1-git-send-email-kwolf@redhat.com>

From: Max Reitz <mreitz@redhat.com>

All error paths after a successful bdrv_open() of target_bs should
contain a bdrv_unref(target_bs). This one did not yet, so add it.

Signed-off-by: Max Reitz <mreitz@redhat.com>
Reviewed-by: Alberto Garcia <berto@igalia.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Fam Zheng <famz@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
 blockdev.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/blockdev.c b/blockdev.c
index 917ae06..07c1741 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -3171,6 +3171,7 @@ static void do_drive_backup(const char *device, const char *target,
         bmap = bdrv_find_dirty_bitmap(bs, bitmap);
         if (!bmap) {
             error_setg(errp, "Bitmap '%s' could not be found", bitmap);
+            bdrv_unref(target_bs);
             goto out;
         }
     }
-- 
1.8.3.1

  parent reply	other threads:[~2015-11-18 16:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-18 16:08 [Qemu-devel] [PULL 0/4] Block patches for 2.5.0-rc1 Kevin Wolf
2015-11-18 16:09 ` [Qemu-devel] [PULL 1/4] nand: fix address overflow Kevin Wolf
2015-11-18 16:09 ` [Qemu-devel] [PULL 2/4] iotests: fix race in 030 Kevin Wolf
2015-11-18 16:09 ` Kevin Wolf [this message]
2015-11-18 16:09 ` [Qemu-devel] [PULL 4/4] block: Call external_snapshot_clean after blockdev-snapshot Kevin Wolf
2015-11-18 20:32 ` [Qemu-devel] [PULL 0/4] Block patches for 2.5.0-rc1 Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1447862943-16071-4-git-send-email-kwolf@redhat.com \
    --to=kwolf@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).