From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36970) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zz5IG-0003JE-Lt for qemu-devel@nongnu.org; Wed, 18 Nov 2015 11:09:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zz5IF-0007PN-Pc for qemu-devel@nongnu.org; Wed, 18 Nov 2015 11:09:12 -0500 From: Kevin Wolf Date: Wed, 18 Nov 2015 17:09:02 +0100 Message-Id: <1447862943-16071-4-git-send-email-kwolf@redhat.com> In-Reply-To: <1447862943-16071-1-git-send-email-kwolf@redhat.com> References: <1447862943-16071-1-git-send-email-kwolf@redhat.com> Subject: [Qemu-devel] [PULL 3/4] blockdev: Add missing bdrv_unref() in drive-backup List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-block@nongnu.org Cc: kwolf@redhat.com, qemu-devel@nongnu.org From: Max Reitz All error paths after a successful bdrv_open() of target_bs should contain a bdrv_unref(target_bs). This one did not yet, so add it. Signed-off-by: Max Reitz Reviewed-by: Alberto Garcia Reviewed-by: Kevin Wolf Reviewed-by: Fam Zheng Signed-off-by: Kevin Wolf --- blockdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/blockdev.c b/blockdev.c index 917ae06..07c1741 100644 --- a/blockdev.c +++ b/blockdev.c @@ -3171,6 +3171,7 @@ static void do_drive_backup(const char *device, const char *target, bmap = bdrv_find_dirty_bitmap(bs, bitmap); if (!bmap) { error_setg(errp, "Bitmap '%s' could not be found", bitmap); + bdrv_unref(target_bs); goto out; } } -- 1.8.3.1