From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <keith.busch@intel.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org
Subject: [Qemu-devel] [PATCH 2/2] nvme: bump PCI revision
Date: Wed, 18 Nov 2015 19:53:12 +0100 [thread overview]
Message-ID: <1447872792-8508-3-git-send-email-hch@lst.de> (raw)
In-Reply-To: <1447872792-8508-1-git-send-email-hch@lst.de>
The broken Identify implementation in earlier Qemu versions means we
need to blacklist it from issueing the NVMe 1.1 Identify Namespace List
command. As we want to be able to use it in newer Qemu versions we need
a way to identify those. Bump the PCI revision as a guest visible
indicator of this bug fix.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
hw/block/nvme.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/block/nvme.c b/hw/block/nvme.c
index 4a6443f..360be71 100644
--- a/hw/block/nvme.c
+++ b/hw/block/nvme.c
@@ -946,7 +946,7 @@ static void nvme_class_init(ObjectClass *oc, void *data)
pc->class_id = PCI_CLASS_STORAGE_EXPRESS;
pc->vendor_id = PCI_VENDOR_ID_INTEL;
pc->device_id = 0x5845;
- pc->revision = 1;
+ pc->revision = 2;
pc->is_express = 1;
set_bit(DEVICE_CATEGORY_STORAGE, dc->categories);
--
1.9.1
next prev parent reply other threads:[~2015-11-18 18:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-18 18:53 [Qemu-devel] [PATCH 0/2] import nvme fix Christoph Hellwig
2015-11-18 18:53 ` [Qemu-devel] [PATCH 1/2] nvme: fix identify to be NVMe 1.1 compliant Christoph Hellwig
2015-11-18 19:21 ` Christoph Hellwig
2015-11-18 18:53 ` Christoph Hellwig [this message]
2015-11-25 9:28 ` [Qemu-devel] [Qemu-block] [PATCH 0/2] import nvme fix Kevin Wolf
2015-11-25 16:44 ` Keith Busch
-- strict thread matches above, loose matches on Subject: below --
2016-08-04 19:42 [Qemu-devel] fix incorrect identify implementation in nvme Christoph Hellwig
2016-08-04 19:42 ` [Qemu-devel] [PATCH 2/2] nvme: bump PCI revision Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1447872792-8508-3-git-send-email-hch@lst.de \
--to=hch@lst.de \
--cc=keith.busch@intel.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).