From: Juan Quintela <quintela@redhat.com>
To: qemu-devel@nongnu.org
Cc: amit.shah@redhat.com, "Denis V. Lunev" <den@openvz.org>,
dgilbert@redhat.com
Subject: [Qemu-devel] [PULL 10/14] migration: drop find_vmstate_bs check in hmp_delvm
Date: Thu, 19 Nov 2015 12:21:05 +0100 [thread overview]
Message-ID: <1447932069-2772-11-git-send-email-quintela@redhat.com> (raw)
In-Reply-To: <1447932069-2772-1-git-send-email-quintela@redhat.com>
From: "Denis V. Lunev" <den@openvz.org>
There is no much sense to do the check and write warning.
Signed-off-by: Denis V. Lunev <den@openvz.org>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Fam Zheng <famz@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Tested-by: Greg Kurz <gkurz@linux.vnet.ibm.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>
---
migration/savevm.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/migration/savevm.c b/migration/savevm.c
index 4e6d578..63c07e1 100644
--- a/migration/savevm.c
+++ b/migration/savevm.c
@@ -2116,11 +2116,6 @@ void hmp_delvm(Monitor *mon, const QDict *qdict)
Error *err;
const char *name = qdict_get_str(qdict, "name");
- if (!find_vmstate_bs()) {
- monitor_printf(mon, "No block device supports snapshots\n");
- return;
- }
-
if (bdrv_all_delete_snapshot(name, &bs, &err) < 0) {
monitor_printf(mon,
"Error while deleting snapshot on device '%s': %s\n",
--
2.5.0
next prev parent reply other threads:[~2015-11-19 11:21 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-19 11:20 [Qemu-devel] [PULL 00/14] Migration pull request Juan Quintela
2015-11-19 11:20 ` [Qemu-devel] [PULL 01/14] Set last_sent_block Juan Quintela
2015-11-19 11:20 ` [Qemu-devel] [PULL 02/14] migration: Dead assignment of current_time Juan Quintela
2015-11-19 11:20 ` [Qemu-devel] [PULL 03/14] Unneeded NULL check Juan Quintela
2015-11-19 11:20 ` [Qemu-devel] [PULL 04/14] snapshot: create helper to test that block drivers supports snapshots Juan Quintela
2015-11-19 11:21 ` [Qemu-devel] [PULL 05/14] snapshot: return error code from bdrv_snapshot_delete_by_id_or_name Juan Quintela
2015-11-19 11:21 ` [Qemu-devel] [PULL 06/14] snapshot: create bdrv_all_delete_snapshot helper Juan Quintela
2015-11-19 11:21 ` [Qemu-devel] [PULL 07/14] snapshot: create bdrv_all_goto_snapshot helper Juan Quintela
2015-11-19 11:21 ` [Qemu-devel] [PULL 08/14] migration: factor our snapshottability check in load_vmstate Juan Quintela
2015-11-19 11:21 ` [Qemu-devel] [PULL 09/14] snapshot: create bdrv_all_find_snapshot helper Juan Quintela
2015-11-19 11:21 ` Juan Quintela [this message]
2015-11-19 11:21 ` [Qemu-devel] [PULL 11/14] snapshot: create bdrv_all_create_snapshot helper Juan Quintela
2015-11-19 11:21 ` [Qemu-devel] [PULL 12/14] migration: reorder processing in hmp_savevm Juan Quintela
2015-11-19 11:21 ` [Qemu-devel] [PULL 13/14] migration: implement bdrv_all_find_vmstate_bs helper Juan Quintela
2015-11-19 11:21 ` [Qemu-devel] [PULL 14/14] migration: normalize locking in migration/savevm.c Juan Quintela
2015-11-19 13:12 ` [Qemu-devel] [PULL 00/14] Migration pull request Peter Maydell
2015-11-19 13:21 ` Peter Maydell
2015-11-19 14:44 ` Peter Maydell
2015-11-19 15:03 ` Peter Maydell
2015-11-19 15:16 ` Dr. David Alan Gilbert
2015-11-20 8:03 ` Peter Lieven
2015-11-20 9:38 ` Peter Lieven
2015-11-20 11:33 ` Peter Maydell
2015-11-20 13:44 ` Peter Lieven
2015-11-20 13:53 ` Kevin Wolf
2015-11-20 14:00 ` Peter Lieven
2015-11-20 14:15 ` Kevin Wolf
2015-11-19 17:32 ` John Snow
2015-11-19 15:56 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1447932069-2772-11-git-send-email-quintela@redhat.com \
--to=quintela@redhat.com \
--cc=amit.shah@redhat.com \
--cc=den@openvz.org \
--cc=dgilbert@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).