From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47931) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZzNHQ-0003a5-DZ for qemu-devel@nongnu.org; Thu, 19 Nov 2015 06:21:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZzNHP-00079j-KQ for qemu-devel@nongnu.org; Thu, 19 Nov 2015 06:21:32 -0500 Received: from mx1.redhat.com ([209.132.183.28]:52818) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZzNHP-00079d-ET for qemu-devel@nongnu.org; Thu, 19 Nov 2015 06:21:31 -0500 From: Juan Quintela Date: Thu, 19 Nov 2015 12:21:05 +0100 Message-Id: <1447932069-2772-11-git-send-email-quintela@redhat.com> In-Reply-To: <1447932069-2772-1-git-send-email-quintela@redhat.com> References: <1447932069-2772-1-git-send-email-quintela@redhat.com> Subject: [Qemu-devel] [PULL 10/14] migration: drop find_vmstate_bs check in hmp_delvm List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: amit.shah@redhat.com, "Denis V. Lunev" , dgilbert@redhat.com From: "Denis V. Lunev" There is no much sense to do the check and write warning. Signed-off-by: Denis V. Lunev Reviewed-by: Stefan Hajnoczi Reviewed-by: Fam Zheng Reviewed-by: Juan Quintela Tested-by: Greg Kurz Signed-off-by: Juan Quintela --- migration/savevm.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/migration/savevm.c b/migration/savevm.c index 4e6d578..63c07e1 100644 --- a/migration/savevm.c +++ b/migration/savevm.c @@ -2116,11 +2116,6 @@ void hmp_delvm(Monitor *mon, const QDict *qdict) Error *err; const char *name = qdict_get_str(qdict, "name"); - if (!find_vmstate_bs()) { - monitor_printf(mon, "No block device supports snapshots\n"); - return; - } - if (bdrv_all_delete_snapshot(name, &bs, &err) < 0) { monitor_printf(mon, "Error while deleting snapshot on device '%s': %s\n", -- 2.5.0