From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34844) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZzPNi-0005Mm-Ai for qemu-devel@nongnu.org; Thu, 19 Nov 2015 08:36:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZzPNe-0005GT-A7 for qemu-devel@nongnu.org; Thu, 19 Nov 2015 08:36:10 -0500 Received: from mx1.redhat.com ([209.132.183.28]:40756) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZzPNe-0005GA-5V for qemu-devel@nongnu.org; Thu, 19 Nov 2015 08:36:06 -0500 Date: Thu, 19 Nov 2015 15:36:02 +0200 From: "Michael S. Tsirkin" Message-ID: <1447939696-28930-3-git-send-email-mst@redhat.com> References: <1447939696-28930-1-git-send-email-mst@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1447939696-28930-1-git-send-email-mst@redhat.com> Subject: [Qemu-devel] [PULL 02/15] vhost: don't send RESET_OWNER at stop List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Peter Maydell , Yuanhan Liu , Jason Wang From: Yuanhan Liu First of all, RESET_OWNER message is sent incorrectly, as it's sent before GET_VRING_BASE. And the reset message would let the later call get nothing correct. And, sending SET_VRING_ENABLE at stop, which has already been done, makes more sense than RESET_OWNER. Signed-off-by: Yuanhan Liu Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/net/vhost_net.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/hw/net/vhost_net.c b/hw/net/vhost_net.c index d91b7b1..14337a4 100644 --- a/hw/net/vhost_net.c +++ b/hw/net/vhost_net.c @@ -292,12 +292,6 @@ static void vhost_net_stop_one(struct vhost_net *net, int r = vhost_ops->vhost_net_set_backend(&net->dev, &file); assert(r >= 0); } - } else if (net->nc->info->type == NET_CLIENT_OPTIONS_KIND_VHOST_USER) { - for (file.index = 0; file.index < net->dev.nvqs; ++file.index) { - const VhostOps *vhost_ops = net->dev.vhost_ops; - int r = vhost_ops->vhost_reset_device(&net->dev); - assert(r >= 0); - } } if (net->nc->info->poll) { net->nc->info->poll(net->nc, true); -- MST