qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Andreas Färber" <afaerber@suse.de>
To: qemu-devel@nongnu.org
Cc: "open list:sPAPR" <qemu-ppc@nongnu.org>,
	"Alexander Graf" <agraf@suse.de>,
	"Andreas Färber" <afaerber@suse.de>,
	"David Gibson" <david@gibson.dropbear.id.au>
Subject: [Qemu-devel] [PULL v2 05/10] ppc: Convert spapr code to use object property iterators
Date: Thu, 19 Nov 2015 15:36:03 +0100	[thread overview]
Message-ID: <1447943768-31393-6-git-send-email-afaerber@suse.de> (raw)
In-Reply-To: <1447943768-31393-1-git-send-email-afaerber@suse.de>

From: "Daniel P. Berrange" <berrange@redhat.com>

Stop directly accessing the Object::properties field data
structure and instead use the formal object property iterator
APIs. This insulates the code from future data structure
changes in the Object struct.

Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
Tested-by: Pavel Fedin <p.fedin@samsung.com>
Signed-off-by: Andreas Färber <afaerber@suse.de>
---
 hw/ppc/spapr_drc.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/hw/ppc/spapr_drc.c b/hw/ppc/spapr_drc.c
index 5d6ea7c..f34bc04 100644
--- a/hw/ppc/spapr_drc.c
+++ b/hw/ppc/spapr_drc.c
@@ -657,6 +657,7 @@ int spapr_drc_populate_dt(void *fdt, int fdt_offset, Object *owner,
 {
     Object *root_container;
     ObjectProperty *prop;
+    ObjectPropertyIterator *iter;
     uint32_t drc_count = 0;
     GArray *drc_indexes, *drc_power_domains;
     GString *drc_names, *drc_types;
@@ -680,7 +681,8 @@ int spapr_drc_populate_dt(void *fdt, int fdt_offset, Object *owner,
      */
     root_container = container_get(object_get_root(), DRC_CONTAINER_PATH);
 
-    QTAILQ_FOREACH(prop, &root_container->properties, node) {
+    iter = object_property_iter_init(root_container);
+    while ((prop = object_property_iter_next(iter))) {
         Object *obj;
         sPAPRDRConnector *drc;
         sPAPRDRConnectorClass *drck;
@@ -721,6 +723,7 @@ int spapr_drc_populate_dt(void *fdt, int fdt_offset, Object *owner,
                                     spapr_drc_get_type_str(drc->type));
         drc_types = g_string_insert_len(drc_types, -1, "\0", 1);
     }
+    object_property_iter_free(iter);
 
     /* now write the drc count into the space we reserved at the
      * beginning of the arrays previously
-- 
2.6.2

  parent reply	other threads:[~2015-11-19 14:36 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-19 14:35 [Qemu-devel] [PULL for-2.5 v2 00/10] QOM devices patch queue 2015-11-19 Andreas Färber
2015-11-19 14:35 ` [Qemu-devel] [PULL v2 01/10] qdev: Change Property::offset field to ptrdiff_t type Andreas Färber
2015-11-19 14:36 ` [Qemu-devel] [PULL v2 02/10] qom: Introduce ObjectPropertyIterator struct for iteration Andreas Färber
2015-11-19 14:36 ` [Qemu-devel] [PULL v2 03/10] qmp: Convert QMP code to use object property iterators Andreas Färber
2015-11-19 14:36 ` [Qemu-devel] [PULL v2 04/10] vl: Convert machine help " Andreas Färber
2015-11-19 14:36 ` Andreas Färber [this message]
2015-11-19 14:36 ` [Qemu-devel] [PULL v2 06/10] net: Convert net filter " Andreas Färber
2015-11-19 14:36 ` [Qemu-devel] [PULL v2 07/10] qom: Add a test case for complex property finalization Andreas Färber
2015-11-19 14:36 ` [Qemu-devel] [PULL v2 08/10] qom: Replace object property list with GHashTable Andreas Färber
2015-11-19 14:36 ` [Qemu-devel] [PULL v2 09/10] qom: Clean up assertions to display values on failure Andreas Färber
2015-11-19 14:36 ` [Qemu-devel] [PULL v2 10/10] MAINTAINERS: Add check-qom-{interface, proplist} to QOM Andreas Färber
2015-11-19 18:34 ` [Qemu-devel] [PULL for-2.5 v2 00/10] QOM devices patch queue 2015-11-19 Peter Maydell
2015-11-20 11:14 ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1447943768-31393-6-git-send-email-afaerber@suse.de \
    --to=afaerber@suse.de \
    --cc=agraf@suse.de \
    --cc=david@gibson.dropbear.id.au \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).