qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: lcapitulino@redhat.com
Subject: [Qemu-devel] [PATCH v2 0/4] json-streamer: Fix up code to limit nesting and size
Date: Thu, 19 Nov 2015 16:29:04 +0100	[thread overview]
Message-ID: <1447946948-12489-1-git-send-email-armbru@redhat.com> (raw)

Ugh, I almost dropped this on the floor.  I think it should go into
2.5, and I plan to take it through my tree.  If you disagree, please
speak up.

We limit nesting depth and input size to defend against input
triggering excessive heap or stack memory use (commit 29c75dd
json-streamer: limit the maximum recursion depth and maximum token
count).  This limiting is flawed in multiple ways.  Fix it up some.

Not yet fixed: this JSON parser is an absurd memory hog; see last
patch.

v2:
* Trivially rebased, R-bys retained
* PATCH 3: Fix a nearby comment typo [Eric]
* PATCH 4: Simplify make_nest() slightly
* PATCH 5: Commit message tweaked

Markus Armbruster (4):
  json-streamer: Apply nesting limit more sanely
  json-streamer: Don't crash when input exceeds nesting limit
  check-qjson: Add test for JSON nesting depth limit
  json-streamer: Limit number of tokens in addition to total size

 qobject/json-streamer.c | 10 ++++++----
 tests/check-qjson.c     | 25 +++++++++++++++++++++++++
 2 files changed, 31 insertions(+), 4 deletions(-)

-- 
2.4.3

             reply	other threads:[~2015-11-19 15:29 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-19 15:29 Markus Armbruster [this message]
2015-11-19 15:29 ` [Qemu-devel] [PATCH v2 1/4] json-streamer: Apply nesting limit more sanely Markus Armbruster
2015-11-19 15:29 ` [Qemu-devel] [PATCH v2 2/4] json-streamer: Don't crash when input exceeds nesting limit Markus Armbruster
2015-11-19 15:29 ` [Qemu-devel] [PATCH v2 3/4] check-qjson: Add test for JSON nesting depth limit Markus Armbruster
2015-11-19 15:29 ` [Qemu-devel] [PATCH v2 4/4] json-streamer: Limit number of tokens in addition to total size Markus Armbruster
2015-11-19 22:01   ` Paolo Bonzini
2015-11-20  6:13     ` Markus Armbruster
2015-11-20  8:50       ` Paolo Bonzini
2015-11-20 17:32         ` Eric Blake
2015-11-23 14:27           ` Paolo Bonzini
2015-11-23 16:03             ` Eric Blake
2015-11-23 17:09               ` Markus Armbruster
2015-11-19 16:15 ` [Qemu-devel] [PATCH v2 0/4] json-streamer: Fix up code to limit nesting and size Eric Blake
2015-11-19 16:59   ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1447946948-12489-1-git-send-email-armbru@redhat.com \
    --to=armbru@redhat.com \
    --cc=lcapitulino@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).