From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35588) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZzR98-0005VE-40 for qemu-devel@nongnu.org; Thu, 19 Nov 2015 10:29:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZzR95-00035s-0s for qemu-devel@nongnu.org; Thu, 19 Nov 2015 10:29:14 -0500 Received: from mx1.redhat.com ([209.132.183.28]:50851) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZzR94-000354-SW for qemu-devel@nongnu.org; Thu, 19 Nov 2015 10:29:10 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 9ED72DF145 for ; Thu, 19 Nov 2015 15:29:10 +0000 (UTC) From: Markus Armbruster Date: Thu, 19 Nov 2015 16:29:07 +0100 Message-Id: <1447946948-12489-4-git-send-email-armbru@redhat.com> In-Reply-To: <1447946948-12489-1-git-send-email-armbru@redhat.com> References: <1447946948-12489-1-git-send-email-armbru@redhat.com> Subject: [Qemu-devel] [PATCH v2 3/4] check-qjson: Add test for JSON nesting depth limit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: lcapitulino@redhat.com This would have prevented the regression mentioned in the previous commit. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- tests/check-qjson.c | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) diff --git a/tests/check-qjson.c b/tests/check-qjson.c index 1cfffa5..61e9bfb 100644 --- a/tests/check-qjson.c +++ b/tests/check-qjson.c @@ -1484,6 +1484,30 @@ static void unterminated_literal(void) g_assert(obj == NULL); } +static char *make_nest(char *buf, size_t cnt) +{ + memset(buf, '[', cnt - 1); + buf[cnt - 1] = '{'; + buf[cnt] = '}'; + memset(buf + cnt + 1, ']', cnt - 1); + buf[2 * cnt] = 0; + return buf; +} + +static void limits_nesting(void) +{ + enum { max_nesting = 1024 }; /* see qobject/json-streamer.c */ + char buf[2 * (max_nesting + 1) + 1]; + QObject *obj; + + obj = qobject_from_json(make_nest(buf, max_nesting)); + g_assert(obj != NULL); + qobject_decref(obj); + + obj = qobject_from_json(make_nest(buf, max_nesting + 1)); + g_assert(obj == NULL); +} + int main(int argc, char **argv) { g_test_init(&argc, &argv, NULL); @@ -1519,6 +1543,7 @@ int main(int argc, char **argv) g_test_add_func("/errors/invalid_array_comma", invalid_array_comma); g_test_add_func("/errors/invalid_dict_comma", invalid_dict_comma); g_test_add_func("/errors/unterminated/literal", unterminated_literal); + g_test_add_func("/errors/limits/nesting", limits_nesting); return g_test_run(); } -- 2.4.3