From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57067) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZzlCD-0007ZX-Lm for qemu-devel@nongnu.org; Fri, 20 Nov 2015 07:53:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZzlCC-00087L-Rm for qemu-devel@nongnu.org; Fri, 20 Nov 2015 07:53:45 -0500 From: Markus Armbruster Date: Fri, 20 Nov 2015 13:53:35 +0100 Message-Id: <1448024015-31081-1-git-send-email-armbru@redhat.com> Subject: [Qemu-devel] [PATCH] block/qapi: Plug memory leak on query-block error path List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, qemu-block@nongnu.org Spotted by Coverity. Signed-off-by: Markus Armbruster --- block/qapi.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/block/qapi.c b/block/qapi.c index d20262d..267f147 100644 --- a/block/qapi.c +++ b/block/qapi.c @@ -436,7 +436,9 @@ BlockInfoList *qmp_query_block(Error **errp) bdrv_query_info(blk, &info->value, &local_err); if (local_err) { error_propagate(errp, local_err); - goto err; + g_free(info); + qapi_free_BlockInfoList(head); + return NULL; } *p_next = info; @@ -444,10 +446,6 @@ BlockInfoList *qmp_query_block(Error **errp) } return head; - - err: - qapi_free_BlockInfoList(head); - return NULL; } BlockStatsList *qmp_query_blockstats(bool has_query_nodes, -- 2.4.3