From: Eric Blake <eblake@redhat.com>
To: qemu-devel@nongnu.org
Cc: armbru@redhat.com, Michael Roth <mdroth@linux.vnet.ibm.com>
Subject: [Qemu-devel] [PATCH v13 05/14] qapi: Inline _make_implicit_tag()
Date: Fri, 20 Nov 2015 10:24:51 -0700 [thread overview]
Message-ID: <1448040300-968-6-git-send-email-eblake@redhat.com> (raw)
In-Reply-To: <1448040300-968-1-git-send-email-eblake@redhat.com>
Now that alternates no longer use an implicit tag, we can
inline _make_implicit_tag() into its one caller,
_def_union_type().
No change to generated code.
Suggested-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Eric Blake <eblake@redhat.com>
---
v13: commit message touchup
v12: new patch
---
scripts/qapi.py | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/scripts/qapi.py b/scripts/qapi.py
index 44b6126..264de63 100644
--- a/scripts/qapi.py
+++ b/scripts/qapi.py
@@ -1318,11 +1318,6 @@ class QAPISchema(object):
typ, info, 'wrapper', [self._make_member('data', typ, info)])
return QAPISchemaObjectTypeVariant(case, typ)
- def _make_implicit_tag(self, type_name, info, variants):
- typ = self._make_implicit_enum_type(type_name, info,
- [v.name for v in variants])
- return QAPISchemaObjectTypeMember('type', typ, False)
-
def _def_union_type(self, expr, info):
name = expr['union']
data = expr['data']
@@ -1336,7 +1331,9 @@ class QAPISchema(object):
else:
variants = [self._make_simple_variant(key, value, info)
for (key, value) in data.iteritems()]
- tag_member = self._make_implicit_tag(name, info, variants)
+ typ = self._make_implicit_enum_type(name, info,
+ [v.name for v in variants])
+ tag_member = QAPISchemaObjectTypeMember('type', typ, False)
members = [tag_member]
self._def_entity(
QAPISchemaObjectType(name, info, base, members,
--
2.4.3
next prev parent reply other threads:[~2015-11-20 17:25 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-20 17:24 [Qemu-devel] [PATCH v13 00/14] qapi member collision (post-introspection cleanups, subset D) Eric Blake
2015-11-20 17:24 ` [Qemu-devel] [PATCH v13 01/14] qobject: Simplify QObject Eric Blake
2015-11-26 14:27 ` Markus Armbruster
2015-11-26 15:06 ` Markus Armbruster
2015-11-20 17:24 ` [Qemu-devel] [PATCH v13 02/14] qobject: Rename qtype_code to QType Eric Blake
2015-11-20 17:24 ` [Qemu-devel] [PATCH v13 03/14] qapi: Convert QType into QAPI built-in enum type Eric Blake
2015-11-26 14:51 ` Markus Armbruster
2015-11-27 5:09 ` Eric Blake
2015-11-20 17:24 ` [Qemu-devel] [PATCH v13 04/14] qapi: Simplify visiting of alternate types Eric Blake
2015-11-20 17:24 ` Eric Blake [this message]
2015-11-20 17:24 ` [Qemu-devel] [PATCH v13 06/14] qapi: Fix alternates that accept 'number' but not 'int' Eric Blake
2015-11-20 17:24 ` [Qemu-devel] [PATCH v13 07/14] qapi: Simplify visits of optional fields Eric Blake
2015-11-20 17:24 ` [Qemu-devel] [PATCH v13 08/14] qapi: Shorter " Eric Blake
2015-11-20 17:24 ` [Qemu-devel] [PATCH v13 09/14] qapi: Prepare new QAPISchemaMember base class Eric Blake
2015-11-20 17:24 ` [Qemu-devel] [PATCH v13 10/14] qapi: Track enum values by QAPISchemaMember, not string Eric Blake
2015-11-26 16:29 ` Markus Armbruster
2015-11-20 17:24 ` [Qemu-devel] [PATCH v13 11/14] qapi: Populate info['name'] for each entity Eric Blake
2015-11-26 16:46 ` Markus Armbruster
2015-11-20 17:24 ` [Qemu-devel] [PATCH v13 12/14] qapi: Enforce (or whitelist) case conventions on qapi members Eric Blake
2015-11-27 9:03 ` Markus Armbruster
2015-12-01 22:35 ` Eric Blake
2015-12-02 8:20 ` Markus Armbruster
2015-12-02 15:47 ` Eric Blake
2015-11-27 9:42 ` Markus Armbruster
2015-12-01 16:12 ` Eric Blake
2015-12-02 10:55 ` Markus Armbruster
2015-11-20 17:24 ` [Qemu-devel] [PATCH v13 13/14] qapi: Move duplicate collision checks to schema check() Eric Blake
2015-11-20 17:25 ` [Qemu-devel] [PATCH v13 14/14] qapi: Detect base class loops Eric Blake
2015-11-27 9:56 ` [Qemu-devel] [PATCH v13 00/14] qapi member collision (post-introspection cleanups, subset D) Markus Armbruster
2015-12-01 16:28 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1448040300-968-6-git-send-email-eblake@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).