[Qemu-devel] [PATCH] qemu-iotests: Add -nographic when starting QEMU in 119 and 120

[Qemu-devel] [PATCH] qemu-iotests: Add -nographic when starting QEMU in 119 and 120

[Fam Zheng]

Otherwise, a window flashes on my desktop (built with SDL). Add this as
other cases have it.

Signed-off-by: Fam Zheng <famz@redhat.com>

---
v2: Fix 119 too. [Max]
---
 tests/qemu-iotests/119 | 2 +-
 tests/qemu-iotests/120 | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/qemu-iotests/119 b/tests/qemu-iotests/119
index 9a11f1b..cc6ec07 100755
--- a/tests/qemu-iotests/119
+++ b/tests/qemu-iotests/119
@@ -49,7 +49,7 @@ echo "{'execute': 'qmp_capabilities'}
       {'execute': 'human-monitor-command',
        'arguments': {'command-line': 'qemu-io drv \"read -P 0 0 64k\"'}}
       {'execute': 'quit'}" \
-    | $QEMU -drive id=drv,if=none,file="$TEST_IMG",driver=nbd \
+    | $QEMU -nographic -drive id=drv,if=none,file="$TEST_IMG",driver=nbd \
             -qmp stdio -nodefaults \
     | _filter_qmp | _filter_qemu_io
 
diff --git a/tests/qemu-iotests/120 b/tests/qemu-iotests/120
index 9f13078..d899a3f 100755
--- a/tests/qemu-iotests/120
+++ b/tests/qemu-iotests/120
@@ -49,7 +49,7 @@ echo "{'execute': 'qmp_capabilities'}
       {'execute': 'human-monitor-command',
        'arguments': {'command-line': 'qemu-io drv \"write -P 42 0 64k\"'}}
       {'execute': 'quit'}" \
-    | $QEMU -qmp stdio -nodefaults \
+    | $QEMU -qmp stdio -nographic -nodefaults \
             -drive id=drv,if=none,file="$TEST_IMG",driver=raw,file.driver=$IMGFMT \
     | _filter_qmp | _filter_qemu_io
 $QEMU_IO -c 'read -P 42 0 64k' "$TEST_IMG" | _filter_qemu_io
-- 
2.4.3

Re: [Qemu-devel] [PATCH] qemu-iotests: Add -nographic when starting QEMU in 119 and 120

[Markus Armbruster]

Fam Zheng <famz@redhat.com> writes:

> Otherwise, a window flashes on my desktop (built with SDL). Add this as
> other cases have it.
>
> Signed-off-by: Fam Zheng <famz@redhat.com>
>
> ---
> v2: Fix 119 too. [Max]
> ---
>  tests/qemu-iotests/119 | 2 +-
>  tests/qemu-iotests/120 | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/qemu-iotests/119 b/tests/qemu-iotests/119
> index 9a11f1b..cc6ec07 100755
> --- a/tests/qemu-iotests/119
> +++ b/tests/qemu-iotests/119
> @@ -49,7 +49,7 @@ echo "{'execute': 'qmp_capabilities'}
>        {'execute': 'human-monitor-command',
>         'arguments': {'command-line': 'qemu-io drv \"read -P 0 0 64k\"'}}
>        {'execute': 'quit'}" \
> -    | $QEMU -drive id=drv,if=none,file="$TEST_IMG",driver=nbd \
> +    | $QEMU -nographic -drive id=drv,if=none,file="$TEST_IMG",driver=nbd \
>              -qmp stdio -nodefaults \
>      | _filter_qmp | _filter_qemu_io
>  
> diff --git a/tests/qemu-iotests/120 b/tests/qemu-iotests/120
> index 9f13078..d899a3f 100755
> --- a/tests/qemu-iotests/120
> +++ b/tests/qemu-iotests/120
> @@ -49,7 +49,7 @@ echo "{'execute': 'qmp_capabilities'}
>        {'execute': 'human-monitor-command',
>         'arguments': {'command-line': 'qemu-io drv \"write -P 42 0 64k\"'}}
>        {'execute': 'quit'}" \
> -    | $QEMU -qmp stdio -nodefaults \
> +    | $QEMU -qmp stdio -nographic -nodefaults \
>              -drive id=drv,if=none,file="$TEST_IMG",driver=raw,file.driver=$IMGFMT \
>      | _filter_qmp | _filter_qemu_io
>  $QEMU_IO -c 'read -P 42 0 64k' "$TEST_IMG" | _filter_qemu_io

-nographic is legacy.  Using legacy options is fine, but I wonder
whether you want -display none here.  Unless you really want to redirect
serial and parallel port, I suspect you do.

Re: [Qemu-devel] [PATCH] qemu-iotests: Add -nographic when starting QEMU in 119 and 120

[Fam Zheng]

On Mon, 11/23 08:33, Markus Armbruster wrote:
> Fam Zheng <famz@redhat.com> writes:
> 
> > Otherwise, a window flashes on my desktop (built with SDL). Add this as
> > other cases have it.
> >
> > Signed-off-by: Fam Zheng <famz@redhat.com>
> >
> > ---
> > v2: Fix 119 too. [Max]
> > ---
> >  tests/qemu-iotests/119 | 2 +-
> >  tests/qemu-iotests/120 | 2 +-
> >  2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/tests/qemu-iotests/119 b/tests/qemu-iotests/119
> > index 9a11f1b..cc6ec07 100755
> > --- a/tests/qemu-iotests/119
> > +++ b/tests/qemu-iotests/119
> > @@ -49,7 +49,7 @@ echo "{'execute': 'qmp_capabilities'}
> >        {'execute': 'human-monitor-command',
> >         'arguments': {'command-line': 'qemu-io drv \"read -P 0 0 64k\"'}}
> >        {'execute': 'quit'}" \
> > -    | $QEMU -drive id=drv,if=none,file="$TEST_IMG",driver=nbd \
> > +    | $QEMU -nographic -drive id=drv,if=none,file="$TEST_IMG",driver=nbd \
> >              -qmp stdio -nodefaults \
> >      | _filter_qmp | _filter_qemu_io
> >  
> > diff --git a/tests/qemu-iotests/120 b/tests/qemu-iotests/120
> > index 9f13078..d899a3f 100755
> > --- a/tests/qemu-iotests/120
> > +++ b/tests/qemu-iotests/120
> > @@ -49,7 +49,7 @@ echo "{'execute': 'qmp_capabilities'}
> >        {'execute': 'human-monitor-command',
> >         'arguments': {'command-line': 'qemu-io drv \"write -P 42 0 64k\"'}}
> >        {'execute': 'quit'}" \
> > -    | $QEMU -qmp stdio -nodefaults \
> > +    | $QEMU -qmp stdio -nographic -nodefaults \
> >              -drive id=drv,if=none,file="$TEST_IMG",driver=raw,file.driver=$IMGFMT \
> >      | _filter_qmp | _filter_qemu_io
> >  $QEMU_IO -c 'read -P 42 0 64k' "$TEST_IMG" | _filter_qemu_io
> 
> -nographic is legacy.  Using legacy options is fine, but I wonder
> whether you want -display none here.  Unless you really want to redirect
> serial and parallel port, I suspect you do.

I was just following other cases, I'm fine with either way but I suspect it's
worth to convert them. So if there is no other problem let's be consistent and
stick to -nographic for now. Thanks for pointing out, though.

Fam

Re: [Qemu-devel] [PATCH] qemu-iotests: Add -nographic when starting QEMU in 119 and 120

[Max Reitz]

[-- Attachment #1: Type: text/plain, Size: 703 bytes --]

On 23.11.2015 03:32, Fam Zheng wrote:
> Otherwise, a window flashes on my desktop (built with SDL). Add this as
> other cases have it.
> 
> Signed-off-by: Fam Zheng <famz@redhat.com>
> 
> ---
> v2: Fix 119 too. [Max]
> ---
>  tests/qemu-iotests/119 | 2 +-
>  tests/qemu-iotests/120 | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

Thanks, applied to my block-next tree:

https://github.com/XanClic/qemu/commits/block-next


(There are basically no reasons in favor of or against taking this in
for 2.5, so I decided in favor of “as few patches during freeze as
possible”. If someone tries to convince me to take it in for 2.5, I
won't have any objections.)

Max


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

Re: [Qemu-devel] [PATCH] qemu-iotests: Add -nographic when starting QEMU in 119 and 120

[Kevin Wolf]

[-- Attachment #1: Type: text/plain, Size: 915 bytes --]

Am 23.11.2015 um 22:15 hat Max Reitz geschrieben:
> On 23.11.2015 03:32, Fam Zheng wrote:
> > Otherwise, a window flashes on my desktop (built with SDL). Add this as
> > other cases have it.
> > 
> > Signed-off-by: Fam Zheng <famz@redhat.com>
> > 
> > ---
> > v2: Fix 119 too. [Max]
> > ---
> >  tests/qemu-iotests/119 | 2 +-
> >  tests/qemu-iotests/120 | 2 +-
> >  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> Thanks, applied to my block-next tree:
> 
> https://github.com/XanClic/qemu/commits/block-next
> 
> 
> (There are basically no reasons in favor of or against taking this in
> for 2.5, so I decided in favor of “as few patches during freeze as
> possible”. If someone tries to convince me to take it in for 2.5, I
> won't have any objections.)

It's clearly a bug fix, minimal diffstat, and as it's in the test suite
not risky at all. Sounds like 2.5 to me.

Kevin

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]