From: Bandan Das <bsd@redhat.com>
To: qemu-devel@nongnu.org
Cc: kraxel@redhat.com
Subject: [Qemu-devel] [PATCH v4 0/4] usb-mtp events support
Date: Mon, 23 Nov 2015 16:37:01 -0500 [thread overview]
Message-ID: <1448314625-3855-1-git-send-email-bsd@redhat.com> (raw)
This series adds support for mtp events that are piggybacked on
top of the Linux provided inotify mechanism. It performs well with some
light unit testing in a linux guest. The mtp share is still read only,
but now the guest will notice updates to the share as long as the
mtp client being used supports it.
v4:
1/4:
Rearrange freeing of objects to avoid use after free
3/4:
Rearrange ifdefs to emit messages only on linux systems and
some additional cleanups
No need to use QLIST_FOREACH_SAFE when getting object handles
because device emulation is single threaded
v3:
3/4:
Add watch on a dir only when guest requests its contents instead
of when the dir is created
Removed some unused trace functions
v2:
1/4: Split up the check in usb_mtp_handle_reset into a new patch
Rerrange the check for a null "o"
2/4:
New patch that handles freeing of objects during a reset
3/4:
Reword comment for DELETE event
Reword comment for CREATE event for directories
Rearrange the inotifyfd reading loop for readability
Check for duplicates when creating a new object
Remove unnecessary enum and replace with mtp event codes
Add ifdefs and empty stubs for non linux systems. Ugly but I really
wanted to minimize ifdef clutter. The other option is to compile
mtp support for linux only but that seems a bit restrictive.
Change behavior for "failed events" Instead of bailing out immediately,
check if there's still some left that we can process.
4/4: No change
Bandan Das (4):
usb-mtp: use a list for keeping track of children
usb-mtp: free objects on a mtp reset
usb-mtp: Add support for inotify based file monitoring
usb-mtp: add support for basic mtp events
hw/usb/dev-mtp.c | 308 +++++++++++++++++++++++++++++++++++++++++++++++++++----
trace-events | 2 +
2 files changed, 292 insertions(+), 18 deletions(-)
--
2.5.0
next reply other threads:[~2015-11-23 21:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-23 21:37 Bandan Das [this message]
2015-11-23 21:37 ` [Qemu-devel] [PATCH v4 1/4] usb-mtp: use a list for keeping track of children Bandan Das
2015-11-23 21:37 ` [Qemu-devel] [PATCH v4 2/4] usb-mtp: free objects on a mtp reset Bandan Das
2015-11-23 21:37 ` [Qemu-devel] [PATCH v4 3/4] usb-mtp: Add support for inotify based file monitoring Bandan Das
2015-11-23 21:37 ` [Qemu-devel] [PATCH v4 4/4] usb-mtp: add support for basic mtp events Bandan Das
2015-11-24 7:29 ` [Qemu-devel] [PATCH v4 0/4] usb-mtp events support Gerd Hoffmann
2015-11-24 23:37 ` Bandan Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1448314625-3855-1-git-send-email-bsd@redhat.com \
--to=bsd@redhat.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).