[Qemu-devel] Build problem with qemu Makefile change

[Qemu-devel] Build problem with qemu Makefile change

[Steve Ellcey]

My qemu build has been failing since this checkin by Michael Roth:

	http://lists.nongnu.org/archive/html/qemu-devel/2015-11/msg03991.html

which changed the top-level Makefile.  Is anyone else seeing this?

I am building a qemu for MIPS on an x86 linux box with:

configure --prefix=/scratch/sellcey/repos/q/install-mips-mti-linux-gnu --disable-tools --disable-system --disable-werror --target-list=mips-linux-user,mipsel-linux-user,mipsn32-linux-user,mipsn32el-linux-user,mips64-linux-user,mips64el-linux-user

make --jobs=3 all
make --jobs=3 install

The error message is:

install -d -m 0755 "/scratch/sellcey/repos/q/install-mips-mti-linux-gnu/bin"
libtool --quiet --mode=install install -c -m 0755  "/scratch/sellcey/repos/q/install-mips-mti-linux-gnu/bin"
libtool: install: you must specify a destination
libtool: install: Try `libtool --help --mode=install' for more information.
make: *** [install] Error 1
Error: Make command failed, stopping build.


If I remove the Makefile patch then my build works and the libtool install
line looks like:

install -d -m 0755 "/scratch/sellcey/repos/q/install-mips-mti-linux-gnu/bin"
libtool --quiet --mode=install install -c -m 0755 qemu-ga  "/scratch/sellcey/repos/q2/install-mips-mti-linux-gnu/bin"

I think the failure may be related to my use of '--disable-tools' or
'--disable-system' in the configure and how this interacts with the
Makefile change.

Steve Ellcey
sellcey@imgtec.com

Re: [Qemu-devel] Build problem with qemu Makefile change

[Michael Roth]

Quoting Steve Ellcey  (2015-11-23 12:06:57)
> My qemu build has been failing since this checkin by Michael Roth:
> 
>         http://lists.nongnu.org/archive/html/qemu-devel/2015-11/msg03991.html
> 
> which changed the top-level Makefile.  Is anyone else seeing this?
> 
> I am building a qemu for MIPS on an x86 linux box with:
> 
> configure --prefix=/scratch/sellcey/repos/q/install-mips-mti-linux-gnu --disable-tools --disable-system --disable-werror --target-list=mips-linux-user,mipsel-linux-user,mipsn32-linux-user,mipsn32el-linux-user,mips64-linux-user,mips64el-linux-user
> 
> make --jobs=3 all
> make --jobs=3 install
> 
> The error message is:
> 
> install -d -m 0755 "/scratch/sellcey/repos/q/install-mips-mti-linux-gnu/bin"
> libtool --quiet --mode=install install -c -m 0755  "/scratch/sellcey/repos/q/install-mips-mti-linux-gnu/bin"
> libtool: install: you must specify a destination
> libtool: install: Try `libtool --help --mode=install' for more information.
> make: *** [install] Error 1
> Error: Make command failed, stopping build.
> 
> 
> If I remove the Makefile patch then my build works and the libtool install
> line looks like:
> 
> install -d -m 0755 "/scratch/sellcey/repos/q/install-mips-mti-linux-gnu/bin"
> libtool --quiet --mode=install install -c -m 0755 qemu-ga  "/scratch/sellcey/repos/q2/install-mips-mti-linux-gnu/bin"
> 
> I think the failure may be related to my use of '--disable-tools' or
> '--disable-system' in the configure and how this interacts with the
> Makefile change.

Looks like --disable-tools results in qemu-ga being
the only entry in $TOOLS.

With the filter added in my patch, this results in install-prog
getting called with an empty list, which generates the error.

So now we need an extra check to avoid calling install-prog with an
empty list. I'll post a patch today. Thanks for the catch.

> 
> Steve Ellcey
> sellcey@imgtec.com
> 

Re: [Qemu-devel] Build problem with qemu Makefile change

[Michael Roth]

Quoting Michael Roth (2015-11-23 12:35:57)
> Quoting Steve Ellcey  (2015-11-23 12:06:57)
> > My qemu build has been failing since this checkin by Michael Roth:
> > 
> >         http://lists.nongnu.org/archive/html/qemu-devel/2015-11/msg03991.html
> > 
> > which changed the top-level Makefile.  Is anyone else seeing this?
> > 
> > I am building a qemu for MIPS on an x86 linux box with:
> > 
> > configure --prefix=/scratch/sellcey/repos/q/install-mips-mti-linux-gnu --disable-tools --disable-system --disable-werror --target-list=mips-linux-user,mipsel-linux-user,mipsn32-linux-user,mipsn32el-linux-user,mips64-linux-user,mips64el-linux-user
> > 
> > make --jobs=3 all
> > make --jobs=3 install
> > 
> > The error message is:
> > 
> > install -d -m 0755 "/scratch/sellcey/repos/q/install-mips-mti-linux-gnu/bin"
> > libtool --quiet --mode=install install -c -m 0755  "/scratch/sellcey/repos/q/install-mips-mti-linux-gnu/bin"
> > libtool: install: you must specify a destination
> > libtool: install: Try `libtool --help --mode=install' for more information.
> > make: *** [install] Error 1
> > Error: Make command failed, stopping build.
> > 
> > 
> > If I remove the Makefile patch then my build works and the libtool install
> > line looks like:
> > 
> > install -d -m 0755 "/scratch/sellcey/repos/q/install-mips-mti-linux-gnu/bin"
> > libtool --quiet --mode=install install -c -m 0755 qemu-ga  "/scratch/sellcey/repos/q2/install-mips-mti-linux-gnu/bin"
> > 
> > I think the failure may be related to my use of '--disable-tools' or
> > '--disable-system' in the configure and how this interacts with the
> > Makefile change.
> 
> Looks like --disable-tools results in qemu-ga being
> the only entry in $TOOLS.
> 
> With the filter added in my patch, this results in install-prog
> getting called with an empty list, which generates the error.
> 
> So now we need an extra check to avoid calling install-prog with an
> empty list. I'll post a patch today. Thanks for the catch.

Patch sent:

  http://article.gmane.org/gmane.comp.emulators.qemu/377965

> 
> > 
> > Steve Ellcey
> > sellcey@imgtec.com
> > 
> 
> 

Re: [Qemu-devel] Build problem with qemu Makefile change

[Steve Ellcey]

On Mon, 2015-11-23 at 16:09 -0600, Michael Roth wrote:

> Patch sent:
> 
>   http://article.gmane.org/gmane.comp.emulators.qemu/377965

The patch works for me.  Thanks for the quick fix.

Steve Ellcey
sellcey@imgtec.com