qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Fam Zheng <famz@redhat.com>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
	vsementsov@virtuozzo.com, qemu-block@nongnu.org,
	Jeff Cody <jcody@redhat.com>,
	mreitz@redhat.com, pbonzini@redhat.com, jsnow@redhat.com
Subject: [Qemu-devel] [PATCH v2 0/3] Bitmap clean-up patches for 2.6
Date: Tue, 24 Nov 2015 13:30:47 +0800	[thread overview]
Message-ID: <1448343050-26595-1-git-send-email-famz@redhat.com> (raw)

v2: bitmap_set -> set_bit. [Congyang, Paolo, John]
    Add John Snow's rev-by with that change.

This makes a cleaner base for more dirty bitmap work. "granularity" appearing
with different representations have always been mind twisting, remove it from
HBitmap to make the interface and implementation simpler. Upon this, it is
a bit easier to add persistent dirty bitmap functionalities.

Block dirty bitmap is not unit-tested, so the removal of HBitmap test code
looks like a loss, but the overall test coverage is barely affected as we also
have various mirror, commit and backup iotest cases, and they do catch various
bugs when I wrote the patches.

Please review!

Fam


Fam Zheng (3):
  backup: Use Bitmap to replace "s->bitmap"
  block: Hide HBitmap in block dirty bitmap interface
  hbitmap: Drop "granularity"

 block.c                |  79 ++++++++++++++-----
 block/backup.c         |  25 +++---
 block/mirror.c         |  14 ++--
 include/block/block.h  |   9 ++-
 include/qemu/hbitmap.h |  20 +----
 tests/test-hbitmap.c   | 206 ++++++++-----------------------------------------
 util/hbitmap.c         |  64 +++------------
 7 files changed, 135 insertions(+), 282 deletions(-)

-- 
2.4.3

             reply	other threads:[~2015-11-24  5:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-24  5:30 Fam Zheng [this message]
2015-11-24  5:30 ` [Qemu-devel] [PATCH v2 1/3] backup: Use Bitmap to replace "s->bitmap" Fam Zheng
2015-11-24  5:30 ` [Qemu-devel] [PATCH v2 2/3] block: Hide HBitmap in block dirty bitmap interface Fam Zheng
2015-11-24  5:30 ` [Qemu-devel] [PATCH v2 3/3] hbitmap: Drop "granularity" Fam Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1448343050-26595-1-git-send-email-famz@redhat.com \
    --to=famz@redhat.com \
    --cc=jcody@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=vsementsov@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).