From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37324) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1AP4-00011N-Mf for qemu-devel@nongnu.org; Tue, 24 Nov 2015 05:00:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a1AP3-0000Dl-Ll for qemu-devel@nongnu.org; Tue, 24 Nov 2015 05:00:50 -0500 Received: from szxga03-in.huawei.com ([119.145.14.66]:27247) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1AP2-0000AT-Io for qemu-devel@nongnu.org; Tue, 24 Nov 2015 05:00:49 -0500 From: zhanghailiang Date: Tue, 24 Nov 2015 17:25:45 +0800 Message-ID: <1448357149-17572-36-git-send-email-zhang.zhanghailiang@huawei.com> In-Reply-To: <1448357149-17572-1-git-send-email-zhang.zhanghailiang@huawei.com> References: <1448357149-17572-1-git-send-email-zhang.zhanghailiang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain Subject: [Qemu-devel] [PATCH COLO-Frame v11 35/39] filter-buffer: Accept zero interval List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: lizhijian@cn.fujitsu.com, quintela@redhat.com, Jason Wang , yunhong.jiang@intel.com, eddie.dong@intel.com, peter.huangpeng@huawei.com, dgilbert@redhat.com, zhanghailiang , arei.gonglei@huawei.com, stefanha@redhat.com, amit.shah@redhat.com, hongyang.yang@easystack.cn For default buffer filter, its 'interval' value is zero, so here we should accept zero interval. Signed-off-by: zhanghailiang Cc: Jason Wang Cc: Yang Hongyang --- v11: - Add comment v10: - new patch --- net/filter-buffer.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/net/filter-buffer.c b/net/filter-buffer.c index 195af68..5cab4fc 100644 --- a/net/filter-buffer.c +++ b/net/filter-buffer.c @@ -116,16 +116,6 @@ static void filter_buffer_setup(NetFilterState *nf, Error **errp) FilterBufferState *s = FILTER_BUFFER(nf); char *path = object_get_canonical_path_component(OBJECT(nf)); - /* - * We may want to accept zero interval when VM FT solutions like MC - * or COLO use this filter to release packets on demand. - */ - if (!s->interval) { - error_setg(errp, QERR_INVALID_PARAMETER_VALUE, "interval", - "a non-zero interval"); - return; - } - s->incoming_queue = qemu_new_net_queue(qemu_netfilter_pass_to_next, nf); s->is_default = !strcmp(path, "nop"); if (s->interval) { -- 1.8.3.1