From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: marcandre.lureau@redhat.com, claudio.fontana@huawei.com
Subject: [Qemu-devel] [PATCH for-2.5 4/5] ivshmem: Mark questionable socket type test FIXME
Date: Tue, 24 Nov 2015 18:06:28 +0100 [thread overview]
Message-ID: <1448384789-14830-5-git-send-email-armbru@redhat.com> (raw)
In-Reply-To: <1448384789-14830-1-git-send-email-armbru@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
hw/misc/ivshmem.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c
index 83d7bd3..a6bfdde 100644
--- a/hw/misc/ivshmem.c
+++ b/hw/misc/ivshmem.c
@@ -939,6 +939,7 @@ static void pci_ivshmem_realize(PCIDevice *dev, Error **errp)
memory_region_add_subregion(&s->bar, 0, mr);
pci_register_bar(PCI_DEVICE(s), 2, attr, &s->bar);
} else if (s->server_chr != NULL) {
+ /* FIXME replace this test, it works basically by chance */
if (strncmp(s->server_chr->filename, "unix:", 5)) {
error_setg(errp, "chardev is not a unix client socket");
return;
--
2.4.3
next prev parent reply other threads:[~2015-11-24 17:06 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-24 17:06 [Qemu-devel] [PATCH for-2.5 0/5] ivshmem: Last minute changes Markus Armbruster
2015-11-24 17:06 ` [Qemu-devel] [PATCH for-2.5 1/5] qemu-doc: Fix ivshmem example markup Markus Armbruster
2015-11-24 17:12 ` Marc-André Lureau
2015-11-24 17:06 ` [Qemu-devel] [PATCH for-2.5 2/5] qemu-doc: Fix ivshmem usage example with shm= Markus Armbruster
2015-11-24 17:14 ` Marc-André Lureau
2015-11-24 17:06 ` [Qemu-devel] [PATCH for-2.5 3/5] tests/ivshmem-test: Supply missing initializer in get_device() Markus Armbruster
2015-11-24 17:16 ` Marc-André Lureau
2015-11-24 17:06 ` Markus Armbruster [this message]
2015-11-24 17:17 ` [Qemu-devel] [PATCH for-2.5 4/5] ivshmem: Mark questionable socket type test FIXME Marc-André Lureau
2015-11-24 17:29 ` Markus Armbruster
2015-11-24 17:42 ` Marc-André Lureau
2015-11-24 18:53 ` Markus Armbruster
2015-11-24 19:52 ` Marc-André Lureau
2015-11-25 8:42 ` Markus Armbruster
2015-11-25 8:46 ` Marc-André Lureau
2015-11-25 9:18 ` Markus Armbruster
2015-11-24 17:06 ` [Qemu-devel] [PATCH for-2.5 5/5] ivshmem: Rename property memdev to x-memdev for 2.5 Markus Armbruster
2015-11-24 17:20 ` Marc-André Lureau
2015-11-24 17:28 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1448384789-14830-5-git-send-email-armbru@redhat.com \
--to=armbru@redhat.com \
--cc=claudio.fontana@huawei.com \
--cc=marcandre.lureau@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).