From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49138) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1XV6-0005UQ-CX for qemu-devel@nongnu.org; Wed, 25 Nov 2015 05:40:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a1XV3-0005XC-1s for qemu-devel@nongnu.org; Wed, 25 Nov 2015 05:40:36 -0500 Received: from mx1.redhat.com ([209.132.183.28]:59489) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1XV2-0005WY-S5 for qemu-devel@nongnu.org; Wed, 25 Nov 2015 05:40:32 -0500 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id E269AC0D2240 for ; Wed, 25 Nov 2015 10:40:31 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-116-45.ams2.redhat.com [10.36.116.45]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id tAPAeUgU000631 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO) for ; Wed, 25 Nov 2015 05:40:31 -0500 From: Markus Armbruster Date: Wed, 25 Nov 2015 11:40:28 +0100 Message-Id: <1448448029-32466-5-git-send-email-armbru@redhat.com> In-Reply-To: <1448448029-32466-1-git-send-email-armbru@redhat.com> References: <1448448029-32466-1-git-send-email-armbru@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PULL for-2.5 4/5] ivshmem: Mark questionable socket type test FIXME List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Signed-off-by: Markus Armbruster Reviewed-by: Marc-Andr=C3=A9 Lureau --- hw/misc/ivshmem.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c index 83d7bd3..edb2270 100644 --- a/hw/misc/ivshmem.c +++ b/hw/misc/ivshmem.c @@ -939,6 +939,7 @@ static void pci_ivshmem_realize(PCIDevice *dev, Error= **errp) memory_region_add_subregion(&s->bar, 0, mr); pci_register_bar(PCI_DEVICE(s), 2, attr, &s->bar); } else if (s->server_chr !=3D NULL) { + /* FIXME do not rely on what chr drivers put into filename */ if (strncmp(s->server_chr->filename, "unix:", 5)) { error_setg(errp, "chardev is not a unix client socket"); return; --=20 2.4.3