From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51687) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1Xgm-0006Ms-0I for qemu-devel@nongnu.org; Wed, 25 Nov 2015 05:52:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a1Xgk-0000Ag-Ta for qemu-devel@nongnu.org; Wed, 25 Nov 2015 05:52:39 -0500 Received: from mx1.redhat.com ([209.132.183.28]:57440) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1Xgk-0000AF-O0 for qemu-devel@nongnu.org; Wed, 25 Nov 2015 05:52:38 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id 669C88E740 for ; Wed, 25 Nov 2015 10:52:38 +0000 (UTC) From: "Daniel P. Berrange" Date: Wed, 25 Nov 2015 10:52:29 +0000 Message-Id: <1448448749-1332-3-git-send-email-berrange@redhat.com> In-Reply-To: <1448448749-1332-1-git-send-email-berrange@redhat.com> References: <1448448749-1332-1-git-send-email-berrange@redhat.com> Subject: [Qemu-devel] [PATCH 2/2] exec: remove warning about mempath and hugetlbfs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Paolo Bonzini , "Michael S. Tsirkin" The gethugepagesize() method in exec.c printed a warning if the file path for "-mem-path" or "-object memory-backend-file" was not on a hugetlbfs filesystem. This warning is bogus, because QEMU functions perfectly well with the path on a regular tmpfs filesystem. Use of hugetlbfs vs tmpfs is a choice for the management application or end user to make as best fits their needs. As such it is inappropriate for QEMU to have an opinion on whether the user's choice is right or wrong in this case. Signed-off-by: Daniel P. Berrange --- exec.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/exec.c b/exec.c index b09f18b..de1cf19 100644 --- a/exec.c +++ b/exec.c @@ -1196,9 +1196,6 @@ static long gethugepagesize(const char *path, Error **errp) return 0; } - if (fs.f_type != HUGETLBFS_MAGIC) - fprintf(stderr, "Warning: path not on HugeTLBFS: %s\n", path); - return fs.f_bsize; } -- 2.5.0