From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46484) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1dj5-0003SY-T1 for qemu-devel@nongnu.org; Wed, 25 Nov 2015 12:19:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a1dj4-0007Wn-PN for qemu-devel@nongnu.org; Wed, 25 Nov 2015 12:19:27 -0500 Received: from mail-wm0-x234.google.com ([2a00:1450:400c:c09::234]:34746) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1dj4-0007WZ-Jb for qemu-devel@nongnu.org; Wed, 25 Nov 2015 12:19:26 -0500 Received: by wmvv187 with SMTP id v187so267286619wmv.1 for ; Wed, 25 Nov 2015 09:19:26 -0800 (PST) Received: from 640k.lan (94-39-152-11.adsl-ull.clienti.tiscali.it. [94.39.152.11]) by smtp.gmail.com with ESMTPSA id b84sm4444274wmh.15.2015.11.25.09.19.25 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 25 Nov 2015 09:19:25 -0800 (PST) Sender: Paolo Bonzini From: Paolo Bonzini Date: Wed, 25 Nov 2015 18:19:13 +0100 Message-Id: <1448471956-66873-7-git-send-email-pbonzini@redhat.com> In-Reply-To: <1448471956-66873-1-git-send-email-pbonzini@redhat.com> References: <1448471956-66873-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PULL 6/9] target-sparc: fix 32-bit truncation in fpackfix List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org This is reported by Coverity. The algorithm description at ftp://ftp.icm.edu.pl/packages/ggi/doc/hw/sparc/Sparc.pdf suggests that the 32-bit parts of rs2, after the left shift, is treated as a 64-bit integer. Bits 32 and above are used to do the saturating truncation. Message-Id: <1446473134-4330-1-git-send-email-pbonzini@redhat.com> Signed-off-by: Paolo Bonzini --- target-sparc/vis_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-sparc/vis_helper.c b/target-sparc/vis_helper.c index 383cc8b..45fc7db 100644 --- a/target-sparc/vis_helper.c +++ b/target-sparc/vis_helper.c @@ -447,7 +447,7 @@ uint32_t helper_fpackfix(uint64_t gsr, uint64_t rs2) for (word = 0; word < 2; word++) { uint32_t val; int32_t src = rs2 >> (word * 32); - int64_t scaled = src << scale; + int64_t scaled = (int64_t)src << scale; int64_t from_fixed = scaled >> 16; val = (from_fixed < -32768 ? -32768 : -- 1.8.3.1