From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PULL for-2.5 02/13] qjson: Apply nesting limit more sanely
Date: Thu, 26 Nov 2015 13:47:47 +0100 [thread overview]
Message-ID: <1448542078-11690-3-git-send-email-armbru@redhat.com> (raw)
In-Reply-To: <1448542078-11690-1-git-send-email-armbru@redhat.com>
The nesting limit from commit 29c75dd "json-streamer: limit the
maximum recursion depth and maximum token count" applies separately to
braces and brackets. This makes no sense. Apply it to their sum,
because that's actually a measure of recursion depth.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Message-Id: <1448486613-17634-2-git-send-email-armbru@redhat.com>
---
qobject/json-streamer.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/qobject/json-streamer.c b/qobject/json-streamer.c
index 1b2f9b1..dced2c7 100644
--- a/qobject/json-streamer.c
+++ b/qobject/json-streamer.c
@@ -64,8 +64,7 @@ static void json_message_process_token(JSONLexer *lexer, QString *token, JSONTok
parser->bracket_count == 0)) {
goto out_emit;
} else if (parser->token_size > MAX_TOKEN_SIZE ||
- parser->bracket_count > MAX_NESTING ||
- parser->brace_count > MAX_NESTING) {
+ parser->bracket_count + parser->brace_count > MAX_NESTING) {
/* Security consideration, we limit total memory allocated per object
* and the maximum recursion depth that a message can force.
*/
--
2.4.3
next prev parent reply other threads:[~2015-11-26 12:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-26 12:47 [Qemu-devel] [PULL for-2.5 00/13] QMP and QObject patches Markus Armbruster
2015-11-26 12:47 ` [Qemu-devel] [PULL for-2.5 01/13] monitor: Plug memory leak on QMP error Markus Armbruster
2015-11-26 12:47 ` Markus Armbruster [this message]
2015-11-26 12:47 ` [Qemu-devel] [PULL for-2.5 03/13] qjson: Don't crash when input exceeds nesting limit Markus Armbruster
2015-11-26 12:47 ` [Qemu-devel] [PULL for-2.5 04/13] check-qjson: Add test for JSON nesting depth limit Markus Armbruster
2015-11-26 12:47 ` [Qemu-devel] [PULL for-2.5 05/13] qjson: Spell out some silent assumptions Markus Armbruster
2015-11-26 12:47 ` [Qemu-devel] [PULL for-2.5 06/13] qjson: Give each of the six structural chars its own token type Markus Armbruster
2015-11-26 12:47 ` [Qemu-devel] [PULL for-2.5 07/13] qjson: Inline token_is_keyword() and simplify Markus Armbruster
2015-11-26 12:47 ` [Qemu-devel] [PULL for-2.5 08/13] qjson: Inline token_is_escape() " Markus Armbruster
2015-11-26 12:47 ` [Qemu-devel] [PULL for-2.5 09/13] qjson: replace QString in JSONLexer with GString Markus Armbruster
2015-11-26 12:47 ` [Qemu-devel] [PULL for-2.5 10/13] qjson: Convert to parser to recursive descent Markus Armbruster
2015-11-26 12:47 ` [Qemu-devel] [PULL for-2.5 11/13] qjson: store tokens in a GQueue Markus Armbruster
2015-11-26 12:47 ` [Qemu-devel] [PULL for-2.5 12/13] qjson: surprise, allocating 6 QObjects per token is expensive Markus Armbruster
2015-11-26 12:47 ` [Qemu-devel] [PULL for-2.5 13/13] qjson: Limit number of tokens in addition to total size Markus Armbruster
2015-11-26 16:50 ` [Qemu-devel] [PULL for-2.5 00/13] QMP and QObject patches Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1448542078-11690-3-git-send-email-armbru@redhat.com \
--to=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).