From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PULL 4/9] exec: remove warning about mempath and hugetlbfs
Date: Thu, 26 Nov 2015 16:52:12 +0100 [thread overview]
Message-ID: <1448553137-22191-5-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1448553137-22191-1-git-send-email-pbonzini@redhat.com>
From: "Daniel P. Berrange" <berrange@redhat.com>
The gethugepagesize() method in exec.c printed a warning if
the file path for "-mem-path" or "-object memory-backend-file"
was not on a hugetlbfs filesystem. This warning is bogus, because
QEMU functions perfectly well with the path on a regular tmpfs
filesystem. Use of hugetlbfs vs tmpfs is a choice for the management
application or end user to make as best fits their needs. As such it
is inappropriate for QEMU to have an opinion on whether the user's
choice is right or wrong in this case.
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
Message-Id: <1448448749-1332-3-git-send-email-berrange@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
exec.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/exec.c b/exec.c
index b09f18b..de1cf19 100644
--- a/exec.c
+++ b/exec.c
@@ -1196,9 +1196,6 @@ static long gethugepagesize(const char *path, Error **errp)
return 0;
}
- if (fs.f_type != HUGETLBFS_MAGIC)
- fprintf(stderr, "Warning: path not on HugeTLBFS: %s\n", path);
-
return fs.f_bsize;
}
--
2.5.0
next prev parent reply other threads:[~2015-11-26 15:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-26 15:52 [Qemu-devel] [PULL v2 0/9] Misc patches for QEMU 2.5-rc2 Paolo Bonzini
2015-11-26 15:52 ` [Qemu-devel] [PULL 1/9] MAINTAINERS: Update TCG CPU cores section Paolo Bonzini
2015-11-26 15:52 ` [Qemu-devel] [PULL 2/9] call bdrv_drain_all() even if the vm is stopped Paolo Bonzini
2015-11-26 15:52 ` [Qemu-devel] [PULL 3/9] Revert "exec: silence hugetlbfs warning under qtest" Paolo Bonzini
2015-11-26 15:52 ` Paolo Bonzini [this message]
2015-11-26 15:52 ` [Qemu-devel] [PULL 5/9] target-sparc: fix 32-bit truncation in fpackfix Paolo Bonzini
2015-11-26 15:52 ` [Qemu-devel] [PULL 6/9] virtio-scsi: don't crash without a valid device Paolo Bonzini
2015-11-26 15:52 ` [Qemu-devel] [PULL 7/9] target-i386: kvm: Abort if MCE bank count is not supported by host Paolo Bonzini
2015-11-26 15:52 ` [Qemu-devel] [PULL 8/9] target-i386: kvm: Use env->mcg_cap when setting up MCE Paolo Bonzini
2015-11-26 15:52 ` [Qemu-devel] [PULL 9/9] target-i386: kvm: Print warning when clearing mcg_cap bits Paolo Bonzini
2015-11-26 16:27 ` [Qemu-devel] [PULL v2 0/9] Misc patches for QEMU 2.5-rc2 Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1448553137-22191-5-git-send-email-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).