From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38577) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1yqS-0005M7-Ux for qemu-devel@nongnu.org; Thu, 26 Nov 2015 10:52:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a1yqR-0001jr-Ss for qemu-devel@nongnu.org; Thu, 26 Nov 2015 10:52:28 -0500 Received: from mx1.redhat.com ([209.132.183.28]:40679) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1yqR-0001jm-Nr for qemu-devel@nongnu.org; Thu, 26 Nov 2015 10:52:27 -0500 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id 670A037EE2 for ; Thu, 26 Nov 2015 15:52:27 +0000 (UTC) Received: from donizetti.redhat.com (ovpn-112-50.ams2.redhat.com [10.36.112.50]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id tAQFqH1N032111 for ; Thu, 26 Nov 2015 10:52:26 -0500 From: Paolo Bonzini Date: Thu, 26 Nov 2015 16:52:13 +0100 Message-Id: <1448553137-22191-6-git-send-email-pbonzini@redhat.com> In-Reply-To: <1448553137-22191-1-git-send-email-pbonzini@redhat.com> References: <1448553137-22191-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PULL 5/9] target-sparc: fix 32-bit truncation in fpackfix List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org This is reported by Coverity. The algorithm description at ftp://ftp.icm.edu.pl/packages/ggi/doc/hw/sparc/Sparc.pdf suggests that the 32-bit parts of rs2, after the left shift, is treated as a 64-bit integer. Bits 32 and above are used to do the saturating truncation. Message-Id: <1446473134-4330-1-git-send-email-pbonzini@redhat.com> Signed-off-by: Paolo Bonzini --- target-sparc/vis_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-sparc/vis_helper.c b/target-sparc/vis_helper.c index 383cc8b..45fc7db 100644 --- a/target-sparc/vis_helper.c +++ b/target-sparc/vis_helper.c @@ -447,7 +447,7 @@ uint32_t helper_fpackfix(uint64_t gsr, uint64_t rs2) for (word = 0; word < 2; word++) { uint32_t val; int32_t src = rs2 >> (word * 32); - int64_t scaled = src << scale; + int64_t scaled = (int64_t)src << scale; int64_t from_fixed = scaled >> 16; val = (from_fixed < -32768 ? -32768 : -- 2.5.0