From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52413) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1zem-0006ID-US for qemu-devel@nongnu.org; Thu, 26 Nov 2015 11:44:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a1zel-0007XO-Oh for qemu-devel@nongnu.org; Thu, 26 Nov 2015 11:44:28 -0500 Received: from mx1.redhat.com ([209.132.183.28]:54633) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1zel-0007XK-JW for qemu-devel@nongnu.org; Thu, 26 Nov 2015 11:44:27 -0500 Date: Thu, 26 Nov 2015 18:44:24 +0200 From: "Michael S. Tsirkin" Message-ID: <1448556198-25213-8-git-send-email-mst@redhat.com> References: <1448556198-25213-1-git-send-email-mst@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1448556198-25213-1-git-send-email-mst@redhat.com> Subject: [Qemu-devel] [PULL 7/9] Revert "vhost: send SET_VRING_ENABLE at start/stop" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Peter Maydell , Yuanhan Liu , Thibaut Collet This reverts commit 3a12f32229a046f4d4ab0a3a52fb01d2d5a1ab76. In case of live migration several queues can be enabled and not only the first one. So informing backend that only the first queue is enabled is wrong. Reported-by: Thibaut Collet Cc: Yuanhan Liu Signed-off-by: Michael S. Tsirkin Reviewed-by: Yuanhan Liu --- hw/virtio/vhost.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c index 1794f0d..de29968 100644 --- a/hw/virtio/vhost.c +++ b/hw/virtio/vhost.c @@ -1226,11 +1226,6 @@ int vhost_dev_start(struct vhost_dev *hdev, VirtIODevice *vdev) } } - if (hdev->vhost_ops->vhost_set_vring_enable) { - /* only enable first vq pair by default */ - hdev->vhost_ops->vhost_set_vring_enable(hdev, hdev->vq_index == 0); - } - return 0; fail_log: vhost_log_put(hdev, false); @@ -1261,10 +1256,6 @@ void vhost_dev_stop(struct vhost_dev *hdev, VirtIODevice *vdev) hdev->vq_index + i); } - if (hdev->vhost_ops->vhost_set_vring_enable) { - hdev->vhost_ops->vhost_set_vring_enable(hdev, 0); - } - vhost_log_put(hdev, true); hdev->started = false; hdev->log = NULL; -- MST