From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52431) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1zet-0006Ti-A8 for qemu-devel@nongnu.org; Thu, 26 Nov 2015 11:44:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a1zeq-0007Xg-3F for qemu-devel@nongnu.org; Thu, 26 Nov 2015 11:44:35 -0500 Date: Thu, 26 Nov 2015 18:44:27 +0200 From: "Michael S. Tsirkin" Message-ID: <1448556198-25213-9-git-send-email-mst@redhat.com> References: <1448556198-25213-1-git-send-email-mst@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1448556198-25213-1-git-send-email-mst@redhat.com> Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PULL 8/9] Fix memory leak on error List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Peter Maydell , Alexander Graf , =?us-ascii?B?PT9VVEYtOD9xP1N0ZWZhbm89MjBEb25nPTIwPTI4PUU4PTkxPUEzPUU1?= =?us-ascii?B?PTg1PUI0PUU2PUIwPUI0PTI5Pz0=?= , qemu-ppc@nongnu.org, Igor Mammedov , David Gibson From: Stefano Dong (=E8=91=A3=E5=85=B4=E6=B0=B4) hw/ppc/spapr.c: Fix memory leak on error, it was introduced in bc09e0611 hw/acpi/memory_hotplug.c: Fix memory leak on error, it was introduced in = 34f2af3d Signed-off-by: Stefano Dong (=E8=91=A3=E5=85=B4=E6=B0=B4) Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/acpi/memory_hotplug.c | 1 + hw/ppc/spapr.c | 1 + 2 files changed, 2 insertions(+) diff --git a/hw/acpi/memory_hotplug.c b/hw/acpi/memory_hotplug.c index ce428df..e4b9a01 100644 --- a/hw/acpi/memory_hotplug.c +++ b/hw/acpi/memory_hotplug.c @@ -155,6 +155,7 @@ static void acpi_memory_hotplug_write(void *opaque, h= waddr addr, uint64_t data, qapi_event_send_mem_unplug_error(dev->id, error_get_pretty(local_= err), &error_abort); + error_free(local_err); break; } trace_mhp_acpi_pc_dimm_deleted(mem_st->selector); diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index 030ee35..3bb8bcd 100644 --- a/hw/ppc/spapr.c +++ b/hw/ppc/spapr.c @@ -125,6 +125,7 @@ static XICSState *xics_system_init(MachineState *mach= ine, error_report("kernel_irqchip requested but unavailable: %s", error_get_pretty(err)); } + error_free(err); } =20 if (!icp) { --=20 MST